Skip to content

Conversation

@jahooma
Copy link
Contributor

@jahooma jahooma commented Jan 28, 2026

No description provided.

Copy link
Collaborator

@brandonkachen brandonkachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for a first pass. but lots of LLM-slop here, particularly code patterns like this:

const customerId =
    typeof stripeSubscription.customer === 'string'
      ? stripeSubscription.customer
      : stripeSubscription.customer.id

we can instead add a generic function to do this:

export function resolveExpandableId<T extends { id: string }>(
  value: string | T,
): string {
  return typeof value === 'string' ? value : value.id
}

const customerId = resolveExpandableId(stripeSubscription.customer)

@@ -1,7 +1,11 @@
import {
grantOrganizationCredits,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole file feels messy; seems like codebuff is trying to shoehorn its conception of the code into the existing thing. we should have codex review and see if there's something better.

@brandonkachen
Copy link
Collaborator

oh and please make sure to run the db migration locally once you're happy with the db schema, so we have all the artifact files that drizzle will apply on prod when you merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants