Skip to content

Early-return missing assignments #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cifarquhar merged 1 commit into from
Dec 18, 2025
Merged

Early-return missing assignments #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/course.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,14 @@ impl CourseScheduleWithRegisterSheetId {
sprints.len()
)));
}
if let Some(assignment) = assignment {
sprints[sprint_index].push(assignment);
}
sprints[sprint_index].push(assignment);
}
}
Ok(sprints)
}
}

fn parse_issue(issue: &Issue) -> Result<Option<(NonZeroUsize, Option<Assignment>)>, Error> {
fn parse_issue(issue: &Issue) -> Result<Option<(NonZeroUsize, Assignment)>, Error> {
if issue.pull_request.is_some() {
return Ok(None);
}
Expand Down Expand Up @@ -232,12 +230,13 @@ fn parse_issue(issue: &Issue) -> Result<Option<(NonZeroUsize, Option<Assignment>
}
};

let Some(assignment) = assignment else {
return Ok(None);
};

let sprint = match sprints.as_slice() {
[sprint] => *sprint,
[] if assignment.is_none() => {
return Ok(None);
}
// If empty (and assignment is not None), or more than one value:
// If empty, or more than one value:
empty_or_more_than_one => {
return Err(Error::UserFacing(format!(
"Failed to parse issue {} - expected exactly one sprint label but got {}",
Expand Down