London_10-Saliha_Popal/ cyf-hotel-react#588
London_10-Saliha_Popal/ cyf-hotel-react#588SalihaPopal wants to merge 13 commits intoCodeYourFuture:masterfrom
Conversation
Installed npm install moment --save and used .diff() method.
| <Heading /> | ||
| <TouristInfoCards /> | ||
| <Bookings /> | ||
| <Footer const ContactInfo = {["123 Fake Street, London, E1 4UD", "hello@fakehotel.com", "0123 456789"]} /> |
There was a problem hiding this comment.
This is not the right syntax for passing a prop into a react component. Could you correct it?
| <div className="container"> | ||
| <Search search={search} /> | ||
| {/* <SearchResults results={FakeBookings} /> */} | ||
| {/* <SearchResults const bookings = {[ |
There was a problem hiding this comment.
It's recommended not to push commented codes :)
| @@ -0,0 +1,16 @@ | |||
| import React from "react"; | |||
|
|
|||
| const Footer = (props) => { | |||
There was a problem hiding this comment.
Have you checked if this component is working as expected? If not could it be due to the syntax error on the top?
| @@ -0,0 +1,43 @@ | |||
| import React from "react"; | |||
|
|
|||
| const TouristInfoCards = () => { | |||
There was a problem hiding this comment.
Can you think of creating some functionalities and not using just html to display cards for each city? this makes your code more efficient and nicer
| </tr> | ||
| ))} | ||
| </tbody> | ||
| </table> |
There was a problem hiding this comment.
Looks that you haven't installed prettier. I recommend going through this instruction and install it. Some of indentions are off :(
migmow
left a comment
migmow
left a comment
There was a problem hiding this comment.
I left some comments Saliha, feel free to get in touch if you need any clarification :)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
No description provided.