Open
Conversation
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Generally LGTM, one thought on encouraging constructive feedback
|
|
||
| 1. **Stay constructive** | ||
|
|
||
| Feedback is always here to help people grow. It might grow their confidence by highlighting what went well, or grow their skill by suggesting areas to improve. Regardless of what the feedback is about, it is always with the goal of improving our peers. |
Member
There was a problem hiding this comment.
Most trainees and volunteers only give positive feedback. I think we may need to reframe this point slightly to encourage feedback that will help people grow.
Particularly given there's a "highlight what went well" section.
A phrase I often use when eliciting feedback is:
"What did you think they did well, and what would you have done differently?" - and try to make sure they say at least one thing for each question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this with the long-term goal to allow demos to be done on Saturdays if needed.
This guidance allows more people to know how to give feedback. Hopefully allowing for better demo feedback, quicker, on Saturdays (alongside a workshop to help this skill grow too... to be designed)