Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 3 | Implement shell tools#408
Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 3 | Implement shell tools#408enjoy15 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
enjoy15
added
📅 Sprint 3
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Generally looking good, but it looks like you're slightly over-fitting to the examples in the README.md - give some thought to other command lines a user may try to run, and how your implementations may be surprising to them.
| let lineNumber = 1; | ||
|
|
||
| files.forEach((file) => { | ||
| const filePath = path.resolve(file); |
There was a problem hiding this comment.
What is this line doing? What would break if you removed it and just used file instead of filePath?
| if (options.numberNonEmpty && line.trim()) { | ||
| console.log(`${lineNumber}\t${line}`); | ||
| lineNumber++; | ||
| } else if (options.numberLines) { | ||
| console.log(`${lineNumber}\t${line}`); | ||
| lineNumber++; | ||
| } else { | ||
| console.log(line); |
There was a problem hiding this comment.
The three branches here look quite similar and repetitive. In general, if you have multiple similar branches, it's more clear to extract the differences into variables, and then run the same code, i.e. so you'd only have one call to console.log which looks more like console.log(`${prefix}${line}\n`) where prefix may be set differently based on options (including potentially an empty string).
This way it's easier for someone reading the code to see what's the same / different in each case, and also avoids the hazard that someone updates one of the branches but forgets to update the other ones.
| } | ||
| }); | ||
| } catch (err) { | ||
| console.error(`cat: ${file}: No such file or directory`); |
There was a problem hiding this comment.
What exit code will your program have if something went wrong? What exit code should it have?
| } | ||
| }); | ||
| } catch (err) { | ||
| console.error(`cat: ${file}: No such file or directory`); |
There was a problem hiding this comment.
Are you sure the problem here is that the file didn't exist? What would happen e.g. if you didn't have permission to read the file?
In general specific error messages are good, but misleadingly specific error messages are a problem - if we're not sure what went wrong (or if we have more information about what went wrong), we should present that information, rather than guessing. And if we are guessing, we should make it clear we're not sure what the problem exactly was and that this is a guess.
| if (arg === '-l') { | ||
| options.lines = true; | ||
| } else if (arg === '-w') { | ||
| options.words = true; | ||
| } else if (arg === '-c') { | ||
| options.bytes = true; | ||
| } else { | ||
| files.push(arg); | ||
| } |
There was a problem hiding this comment.
What happens if someone specifies more than one of these flags? What should happen?
Given the test cases we gave you in the README file, it's ok if your implementation doesn't do the same thing as the real wc does, though that would be ideal, but in general ignoring user input is bad - so if someone asks for both -l and -c and you ignore one of them, that can be confusing. Either showing both, or giving an error, is probably preferable.
| } | ||
|
|
||
| files.forEach((file) => { | ||
| const filePath = path.resolve(file); |
There was a problem hiding this comment.
Again, why do you need the path.resolve here?
| } else if (arg === '-a') { | ||
| options.all = true; | ||
| } else { | ||
| directories = [arg]; |
There was a problem hiding this comment.
This meets the requirements for the examples listed in the README.md, but feels like it risks being confusing to users. If someone specified ls /some/path /some/other/path what do you think they would expect to happen? What does your code actually do? (See also the comment about wc options for a similar question)
illicitonion
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Completed all exercises