Sheffield | 2026-MAR-SDC | Jak Rhodes-Smith | Sprint 4 | Implement shell tools in Python#390
Closed
jakr-s wants to merge 5 commits intoCodeYourFuture:mainfrom
Closed
Sheffield | 2026-MAR-SDC | Jak Rhodes-Smith | Sprint 4 | Implement shell tools in Python#390jakr-s wants to merge 5 commits intoCodeYourFuture:mainfrom
jakr-s wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
Member
illicitonion
left a comment
There was a problem hiding this comment.
This is looking really good, well done!
Are you using a formatter for this code? In a few places the line wrapping makes the code less clear to read, I'm not sure if you're doing that manually or if something is doing it for you?
Author
Yeah it's just the formatter doing the line wrapping, I'm using the autopep8 extension since I wasn't doing too well with manual indentation 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Converted all JavaScript shell tools to Python