Skip to content

London | 26-SDC-Mar | Mariia Serhiienko | Sprint 1 | Number systems#387

Open
Konvaly wants to merge 1 commit intoCodeYourFuture:mainfrom
Konvaly:number-systems
Open

London | 26-SDC-Mar | Mariia Serhiienko | Sprint 1 | Number systems#387
Konvaly wants to merge 1 commit intoCodeYourFuture:mainfrom
Konvaly:number-systems

Conversation

@Konvaly
Copy link
Copy Markdown

@Konvaly Konvaly commented Mar 18, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Solved task number-systems.

@Konvaly Konvaly added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2026
cjyuan
cjyuan reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a self-check against the answers on https://github.com/CodeYourFuture/Module-Tools/blob/solutions/number-systems/README.md?plain=1

Should you have any question regarding number systems, feel free to raise them in the comment of this PR.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026
@Konvaly
Copy link
Copy Markdown
Author

Konvaly commented Mar 25, 2026

Can you do a self-check against the answers on https://github.com/CodeYourFuture/Module-Tools/blob/solutions/number-systems/README.md?plain=1

Should you have any question regarding number systems, feel free to raise them in the comment of this PR.

Hi @cjyuan !
Thank you for reviewing my PR.

I've done self-check my answers and noticed that they are correct but in some of them I added more explanation/solution than it shown.

Do I have to rewrite these answers?

Thanks again!

@cjyuan
Copy link
Copy Markdown

cjyuan commented Mar 25, 2026

If you have checked the answers and have no follow-up questions, then that's all I need to know.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Konvaly @cjyuan