Skip to content

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Number systems#360

Open
TarasMykytiuk wants to merge 2 commits intoCodeYourFuture:mainfrom
TarasMykytiuk:number_systems
Open

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Number systems#360
TarasMykytiuk wants to merge 2 commits intoCodeYourFuture:mainfrom
TarasMykytiuk:number_systems

Conversation

@TarasMykytiuk
Copy link
Copy Markdown

@TarasMykytiuk TarasMykytiuk commented Mar 12, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Number systems exercises are done.

@github-actions

This comment has been minimized.

@TarasMykytiuk TarasMykytiuk added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@github-actions

This comment has been minimized.

5 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TarasMykytiuk TarasMykytiuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@TarasMykytiuk TarasMykytiuk changed the title Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Number Systems Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Number systems Mar 12, 2026
@github-actions

This comment has been minimized.

@TarasMykytiuk TarasMykytiuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@TarasMykytiuk TarasMykytiuk added Module-Tools The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a self-check against the answers on https://github.com/CodeYourFuture/Module-Tools/blob/solutions/number-systems/README.md?plain=1

Should you have any question regarding number systems, feel free to raise them in the comment of this PR.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026
@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 27, 2026
@TarasMykytiuk
Copy link
Copy Markdown
Author

Can you do a self-check against the answers on https://github.com/CodeYourFuture/Module-Tools/blob/solutions/number-systems/README.md?plain=1

Should you have any question regarding number systems, feel free to raise them in the comment of this PR.

Hi @cjyuan . Thanks for review. I have fixed conversion from hex to decimal.
I compared my other answers to self-check.
Is that answer enough?:

"How can you test if a binary number is a power of two (e.g. 1, 2, 4, 8, 16, ...)?
Answer: Test that it has exactly one 1."

@cjyuan
Copy link
Copy Markdown

cjyuan commented Mar 27, 2026

Change looks good.

"How can you test if a binary number is a power of two (e.g. 1, 2, 4, 8, 16, ...)?
Answer: Test that it has exactly one 1."

Aren't you curious how to implement such a check in JS or in Python?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 27, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented Mar 27, 2026

The approach involving log() function may not be 100% accurate because of floating point arithmetic, and is relatively slower than an approach that involves only one bit-wise and one arithmetic operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Tools The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants