Sheffield | 26-Jan-ITP | Seti Mussa | sprint 3 | coursework implement and rewrite #1278
Open
Seti-Jemal wants to merge 12 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Seti Mussa | sprint 3 | coursework implement and rewrite #1278Seti-Jemal wants to merge 12 commits intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 12 commits intoCodeYourFuture:mainfrom
Conversation
Seti-Jemal
added
the
Needs Review
Seti-Jemal
changed the title
Seti-Jemal
added
📅 Sprint 3
cjyuan
reviewed
Mar 21, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
The
isProperFraction()function is not quite correct. The other two functions are good. -
This exercise also expects you to implement the Jest tests in the
rewrite-tests-with-jestfolder.
Comment on lines
+34
to
+44
| assertEquals(isProperFraction(3, 5), true); | ||
| assertEquals(isProperFraction(4, 8), true); | ||
| assertEquals(isProperFraction(-1, 2), true); | ||
| assertEquals(isProperFraction(-1, -2), true); | ||
| assertEquals(isProperFraction(1, -2), true); | ||
|
|
||
| //Not | ||
| assertEquals(isProperFraction(9, 7), false); | ||
| assertEquals(isProperFraction(13, 11), false); | ||
| assertEquals(isProperFraction(19, 10), false); | ||
| assertEquals(isProperFraction(17, 3), false); |
Contributor
There was a problem hiding this comment.
-
Your current function cannot yet pass all these tests.
-
You can also test some improper fractions with negative numerator or/and denominator.
Author
There was a problem hiding this comment.
I have applied the feedbacks.
Contributor
There was a problem hiding this comment.
-
If you have made any new commit, don't forget to push the commit also to GitHub.
-
If your PR is ready to be re-reviewed, don't forget to add the "Needs Review" label.
cjyuan
added
Reviewed
…github.com/Seti-Jemal/Module-Structuring-and-Testing-Data into coursework-sprint-3--implement-and-rewrite
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Mar 27, 2026
Comment on lines
+18
to
+35
| test(`should return true when numerator is less than denominator`, () => { | ||
| expect(isProperFraction(5, 9)).toEqual(true); | ||
| }); | ||
|
|
||
| // Special case; negative numerator and positive denominatore | ||
| test(` should return true when numertaor is negative and less than demoniator`, () => { | ||
| expect(isProperFraction(-5, 9)).toEqual(true); | ||
| }); | ||
|
|
||
| // special case: postive numerator and negative deminator | ||
| test(`should return true when numerator is positive and less than denominator`, () => { | ||
| expect(isProperFraction(5, -9)).toEqual(true); | ||
| }); | ||
|
|
||
| // Special case: negative numerator and negative denominator | ||
| test(`should return true when both are negative`, () => { | ||
| expect(isProperFraction(-5, -9)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
These descriptions are not quite correct without mentioning the comparison is to be made on their absolute value. For example, 5 is actually more than -9, but abs(5) < abs(9).
Note: We can use pseudo-code and notations like abs(...) or | ... | in the descriptions to more
concisely describe the conditions (the "when" part).
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have completed the Sprint 3 implement and rewrite test
Questions
N/A