London | 26-ITP-Jan | Carlos Abreu | Sprint 3 | Refactoring Dead Code

[carlosyabreu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

PR for Sprint-3 of Refactoring dead code

[SlideGauge]

Dead code removed correctly, my main concern is the way how code is organized: we have old code in comments and new code. Could you just remove the dead code, as the task asks?

[SlideGauge]

package.json and package-lock.json should not be in gitignore
Also, will *package.json ignore only one type of filename?

[carlosyabreu]

Evening @SlideGauge
Thank for the feedback.
I remove the old code on the implementation and made it more cleaner.
Thanks for info not to include package.json and package-lock.json file in .gitignore.
I didn't know that.
About the last question, package.json when put in .gitignore fiel will ignore any files that end with package.json. In other words all files () with suffixes package.json

[SlideGauge]

Nice job, complete