Skip to content

Commit 146c90c

Browse files
committed
chore: save progress — implementations and tests
1 parent 63df014 commit 146c90c

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ function isProperFraction(numerator, denominator) {
1616
return false;
1717
}
1818
return Math.abs(numerator) < Math.abs(denominator);
19-
2019
}
2120

2221
// The line below allows us to load the isProperFraction function into tests in other files.
@@ -42,7 +41,7 @@ assertEquals(isProperFraction(4, 2), false);
4241
assertEquals(isProperFraction(0, 2), true);
4342
assertEquals(isProperFraction(2, 0), false);
4443
assertEquals(isProperFraction(0, -5), true);
45-
assertEquals(isProperFraction(
44+
assertEquals(isProperFraction(5, 0), false);
4645

4746
assertEquals(isProperFraction(3, 3), false);
4847
assertEquals(isProperFraction(-3, 3), false);
@@ -51,4 +50,11 @@ assertEquals(isProperFraction(-3, -3), false);
5150

5251
assertEquals(isProperFraction(-1, 2), true);
5352
assertEquals(isProperFraction(1, -2), true);
54-
assertEquals(isProperFraction(-3, -4), true);
53+
assertEquals(isProperFraction(-3, -4), true);
54+
55+
assertEquals(isProperFraction(0.5, 1), true);
56+
assertEquals(isProperFraction(1.5, 1), false);
57+
assertEquals(isProperFraction(1.1, 1), false);
58+
59+
assertEquals(isProperFraction(1e9, 1e10), true);
60+
assertEquals(isProperFraction(1e10, 1e9), false);

0 commit comments

Comments
 (0)