added Jest tests covering positives, negatives, zeros and decimals

Author: Zadri415

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -16,6 +16,7 @@ function isProperFraction(numerator, denominator) {
     return false;
   }
   return Math.abs(numerator) < Math.abs(denominator);
+  
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -35,3 +36,19 @@ function assertEquals(actualOutput, targetOutput) {
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
+assertEquals(isProperFraction(2, 4), true);
+assertEquals(isProperFraction(4, 2), false);
+
+assertEquals(isProperFraction(0, 2), true);
+assertEquals(isProperFraction(2, 0), false);
+assertEquals(isProperFraction(0, -5), true);
+assertEquals(isProperFraction(
+
+assertEquals(isProperFraction(3, 3), false);
+assertEquals(isProperFraction(-3, 3), false);
+assertEquals(isProperFraction(3, -3), false);
+assertEquals(isProperFraction(-3, -3), false);
+
+assertEquals(isProperFraction(-1, 2), true);
+assertEquals(isProperFraction(1, -2), true);
+assertEquals(isProperFraction(-3, -4), true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,6 +23,19 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
+  if (typeof card !== "string") {
+    throw new Error("Card must be a string");
+  }
+
+  const match = card.match(/^(A|10|[2-9]|J|Q|K)([♠♥♦♣])$/);
+  if (!match) {
+    throw new Error("Invalid card format");
+  }
+
+  const rank = match[1];
+  if (rank === "A") return 11;
+  if (rank === "J" || rank === "Q" || rank === "K") return 10;
+  return Number(rank);
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -5,10 +5,28 @@ const getCardValue = require("../implement/3-get-card-value");
 // TODO: Write tests in Jest syntax to cover all possible outcomes.
 
 // Case 1: Ace (A)
-test(`Should return 11 when given an ace card`, () => {
+test("Should return 11 when given an ace card", () => {
   expect(getCardValue("A♠")).toEqual(11);
 });
 
+test("face cards return 10", () => {
+  expect(getCardValue("J♣")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
+  expect(getCardValue("K♦")).toEqual(10);
+});
+
+test("number cards return their numeric value", () => {
+  expect(getCardValue("2♥")).toEqual(2);
+  expect(getCardValue("10♥")).toEqual(10);
+  expect(getCardValue("9♥")).toEqual(9);
+});
+
+test("invalid input throw", () => {
+  expect(() => getCardValue("invalid")).toThrow();
+  expect(() => getCardValue("A")).toThrow();
+  expect(() => getCardValue(null)).toThrow();
+});
+
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
 //   Face Cards (J, Q, K)
@@ -17,4 +35,3 @@ test(`Should return 11 when given an ace card`, () => {
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-