London | May - 26 | Vito Moratti | Sprint 1 | Form-Controls#1372
London | May - 26 | Vito Moratti | Sprint 1 | Form-Controls#1372vmoratti wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vmoratti
added
Needs Review
Note: There are special Markdown syntax for formatting checkboxes on GitHub. |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is error free and well formatted. Well done. I just have one request and some comments.
Note: If you haven't yet enabled "Format on save" on VS Code, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
| <fieldset> | ||
| <legend style="font-weight: bold;">Name and Email address</legend><!--Adding <legend> element for accessibility purposes--> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="name" required><br><br><!--Input field for name, making it required--> |
There was a problem hiding this comment.
The spec has this requirement
What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
Can you update this input field to enforce that requirement?
| <label for="Blue"> | ||
| <input type="radio" id="Blue" name="colour" required>Blue | ||
| </label> |
There was a problem hiding this comment.
Note: If you embed <input> within <label>, use of id and for attributes are optional.
|
|
||
|
|
||
| <fieldset> | ||
| <legend style="font-weight: bold;">Please select a colour for your T-Shirt</legend> |
There was a problem hiding this comment.
Note: Best practice is to move the CSS into an external .css file instead using inline CSS or embedding them within the HTML document. This improves maintainability, keeps the markup cleaner, and makes it easier to locate, update, and reuse styles across multiple pages.
No change is needed for this exercise.
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
After long struggle and then help from classmate. I am hopping to finally submit it.