Cape Town | 26-ITP-MAY | LIYEMA MFENGWANA | Sprint 2 | WIREFRAME#1370
Cape Town | 26-ITP-MAY | LIYEMA MFENGWANA | Sprint 2 | WIREFRAME#1370LiyemaMfengwana wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
force-pushed
the
wireframe-sprint2
branch
from
99e60ca to
cbd2e26
Compare
LiyemaMfengwana
added
the
Needs Review
|
all my previous commits are gone cause i had fix a pull request issue |
|
You don't have to include in the PR description the "answers" to the questions in the README file. However, your PR description is missing a "Changelist" section. |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of error. Page layout looks good.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
To better match the wireframe, can you make the "Read More" link fully aligned horizontally?
There was a problem hiding this comment.
-
It appears that some CSS selectors in this file do not match any elements in the HTML. As a best practice, unused code should be removed to keep the codebase clean and maintainable.
-
Some of the code is not consistent formatted.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
| <article class="card"> | ||
| <div class="card__media"> | ||
| <img src="https://images.unsplash.com/photo-1555949963-aa79dcee981c" | ||
| alt="Developer working with Git and code"> | ||
| </div> | ||
| <div class="card__body"> | ||
| <h2 class="card__title">What is a branch in Git?</h2> | ||
| <p class="card__summary"> |
There was a problem hiding this comment.
Please note that in practice adding elements that are not included in the wireframe may not be advisable, as it can lead to deviations from the intended design.
No change needed.
cjyuan
added
Reviewed
2 participants
Self checklist
A README file explains what a project is and how to use it, a wireframe is a simple layout plan that shows how a webpage will look before it is designed, and a Git branch is a separate version of a project used to work on changes without affecting the main code.