Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe#1365
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe#1365asandagwala wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
To better align with the wireframe, can you
- Make the page title centered
- Keep the title and the "Read more" link of articles 2 and 3 fully aligned horizontally
| </article> | ||
| <article> | ||
| <img src ="logo.jpg" alt = "A picture of a README template"> | ||
| <h2>What is the purpose of a README FILE</h2> |
There was a problem hiding this comment.
Indentation is off.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
There was a problem hiding this comment.
There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
| main article:first-child img{ | ||
| height:300px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we keep main article:first-child img next to the main selector? Grouping selectors that start with main together makes them easier to locate and scan when reviewing or updating the selector list. You could even use the nested syntax.

Self checklist
Changelist