Manchester | 26-ITP-May | Yee Man Tsang | Sprint 2 | Wireframe to Web Code#1349
Open
lintsang wants to merge 4 commits into
Open
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 2 | Wireframe to Web Code#1349lintsang wants to merge 4 commits into
lintsang wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lintsang
added
the
Needs Review
LonMcGregor
reviewed
May 30, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task. There are a few things left to have another look at - see my comments.
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <div id="wrapper"> |
There was a problem hiding this comment.
What is the purpose of this wrapper div?
| <main> | ||
| <article> | ||
| <div class="image-wrapper"> | ||
| <img src="https://cdn.iconscout.com/icon/free/png-512/free-readme-logo-icon-svg-download-png-3029134.png" alt="" /> |
There was a problem hiding this comment.
Should the alt attribute in these images be empty?
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| <div id="wrapper"> |
There was a problem hiding this comment.
What is this wrapper div here doing?
| </p> | ||
| <div id="wrapper"> | ||
| <p> | ||
| By Lin Tsang. This webpage serves as a test environment. Some images and media displayed on this site are sourced from external websites for demonstrative and educational purposes. All copyrights, trademarks, and intellectual property regarding these images remain the property of their respective owners. https://iconscout.com/ |
There was a problem hiding this comment.
Are you sure this footer is fixed to the bottom of the viewport?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I finished this exercise by updating the html and css files provided by following all requirements and wireframe.