London | 26-ITP-May | Martin Mwaka | Sprint 2 | Wireframe#1308
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
left a comment
There was a problem hiding this comment.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
It's important to read the specification carefully to ensure the implementation meets all requirements. Besides the footer, can you review the specification and identify any other requirements that are missing or not correctly implemented in your solution? You can just describe them in the PR comment.
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| Chickpeas, also known as garbanzo beans, are tiny legumes with big nutritional benefits, earning them the title of a superfood. Packed with plant-based protein, chickpeas are excellent for muscle repair ... | ||
| </p> |
There was a problem hiding this comment.
Breaking HTML text into multiple lines helps make the code easier to read, edit, and maintain while preserving the same rendered output.
VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.
For more info about enabling "Format on Save" in VS Code or use VS Code's "Format Document" feature,
please refer to this guide.
|
Not all comments were addressed:
|
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
Can you remove all unused files from the branch to keep it clean? I will mark this PR as complete first.

Self checklist
Changelist
I have forked and cloned the wireframe repository and created a branch on my local vs code name "sprint2_wireframe". Using the provided starter wireframe I have completed the html and css as per the requirements for sprint 2, wireframe task, namely: