Skip to content

London | 26-ITP-May | Martin Mwaka | Sprint 2 | Wireframe#1308

Open
Temceo wants to merge 19 commits into
CodeYourFuture:mainfrom
Temceo:sprint2_wireframe
Open

London | 26-ITP-May | Martin Mwaka | Sprint 2 | Wireframe#1308
Temceo wants to merge 19 commits into
CodeYourFuture:mainfrom
Temceo:sprint2_wireframe

Conversation

@Temceo
Copy link
Copy Markdown

@Temceo Temceo commented May 18, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have forked and cloned the wireframe repository and created a branch on my local vs code name "sprint2_wireframe". Using the provided starter wireframe I have completed the html and css as per the requirements for sprint 2, wireframe task, namely:

  1. What is the purpose of a README file?
  2. What is the purpose of a wireframe?
  3. What is a branch in Git?

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 19243a8
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1afd4cbf43ff000867569e
😎 Deploy Preview https://deploy-preview-1308--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Temceo Temceo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  2. It's important to read the specification carefully to ensure the implementation meets all requirements. Besides the footer, can you review the specification and identify any other requirements that are missing or not correctly implemented in your solution? You can just describe them in the PR comment.

Comment thread Wireframe/index.html
Comment on lines 38 to 40
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
Chickpeas, also known as garbanzo beans, are tiny legumes with big nutritional benefits, earning them the title of a superfood. Packed with plant-based protein, chickpeas are excellent for muscle repair ...
</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking HTML text into multiple lines helps make the code easier to read, edit, and maintain while preserving the same rendered output.

VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.

For more info about enabling "Format on Save" in VS Code or use VS Code's "Format Document" feature,
please refer to this guide.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 25, 2026
@Temceo Temceo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 30, 2026

Not all comments were addressed:

  1. It's important to read the specification carefully to ensure the implementation meets all requirements. Besides the footer, can you review the specification and identify any other requirements that are missing or not correctly implemented in your solution? You can just describe them in the PR comment.

  2. Why not use VS Code formatter to keep the code consistently formatted?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@Temceo Temceo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Well done.

Can you remove all unused files from the branch to keep it clean? I will mark this PR as complete first.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants