London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls by Temceo · Pull Request #1254 · CodeYourFuture/Module-Onboarding

Temceo · 2026-05-12T08:30:53Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Briefly explain your PR.
I have forked the original form controls and made updates on a branch (sprint1_control_forms).
I have add a new form using semantic html with labels and controls for entry of name, email, colour and sizes

netlify · 2026-05-12T08:31:00Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`c15ae5d`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1a8cae354ddf0008f740a3
😎 Deploy Preview	https://deploy-preview-1254--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-05-12T08:31:13Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-12T08:34:37Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sambuxc · 2026-05-12T16:18:19Z

If you're having difficulty with the automated PR checks please reach out in slack.
Make sure to add all required fields in the PR description that follow this format:

All self checklist items are ticked (with a [x]) - watch out for stray spacing
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

github-actions · 2026-05-13T14:18:50Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-13T14:19:45Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-13T14:19:46Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-13T14:20:39Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-15T12:54:34Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-15T13:11:03Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-15T13:17:17Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-15T13:18:13Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-15T13:18:14Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

LonMcGregor

Good start on the form controls task, see my comment for one thing to improve.

Could you fix the submission so that it does not contain the changes to the wireframe task please? We want submissions to only cover one specific task at a time.

LonMcGregor · 2026-05-27T10:01:55Z

+        <div class="form-group">
+           <!-- Add input for name - required and validate -->
+          <label for="name">Name</label>
+          <input type="text" id="name" placeholder="Joe Bloggs" required>


Does the task criteria mention something about a minimum length?

github-actions · 2026-05-27T10:02:55Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-27T10:02:56Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:14:30Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:14:30Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:18:30Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:19:27Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:29:33Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:32:52Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:33:11Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T07:33:25Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-05-30T09:01:49Z

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

All self checklist items are ticked (with a [x])
The "Changelist" section is filled with details of what your PR does.
The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Temceo added 4 commits May 9, 2026 21:11

add fields to form

a18892f

update html and add style.css

ef44f77

add colour styles

62005c6

update button background colour

03dd0c2

Temceo added the Module-Onboarding The name of the module. label May 12, 2026

Temceo marked this pull request as draft May 12, 2026 08:35

Temceo marked this pull request as ready for review May 12, 2026 20:11

update min width of form

eb46639

Sambuxc added the Complete Volunteer to add when work is complete and all review comments have been addressed. label May 13, 2026

Sambuxc added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels May 13, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 13, 2026

Sambuxc added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 13, 2026

Temceo added the 🏕 Priority Mandatory This work is expected label May 15, 2026

Temceo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 🏕 Priority Mandatory This work is expected labels May 15, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 15, 2026

LonMcGregor reviewed May 27, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026

Temceo added 2 commits May 29, 2026 09:40

update html and css files

7a1a2e7

add minimum length requiruement for username

c15ae5d

Temceo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

Temceo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

Temceo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

Temceo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

Temceo removed the Module-Onboarding The name of the module. label May 30, 2026

Temceo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026

Temceo closed this May 30, 2026

Uh oh!

Conversation

Temceo commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

netlify Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Sambuxc commented May 12, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor May 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Temceo commented May 12, 2026 •

edited

Loading

netlify Bot commented May 12, 2026 •

edited

Loading