Skip to content

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Bug Report: Hashtag link doesn't work correctly #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HassanOHOsman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Bug Report: Hashtag link doesn't work correctly #151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac77b3
Fix hashtag regex in _formatHashtags to match only word characters an…
HassanOHOsman Feb 18, 2026
eb09c47
Get rid of un-used var tag inside _formatHashtags function
HassanOHOsman Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions front-end/components/bloom.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ const createBloom = (template, bloom) => {
function _formatHashtags(text) {
if (!text) return text;
return text.replace(
/\B#[^#]+/g,
(match) => `<a href="/hashtag/${match.slice(1)}">${match}</a>`
);
/\B#\w+/g,
(match) => {
const tag = match.slice(1);
return `<a href="/hashtag/${match.slice(1)}">${match}</a>`;
Copy link
Copy Markdown

@OracPrime OracPrime Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've extracted the match to tag, but then re-extracted it. You either need to lose line 42 or use tag in line 43!

Copy link
Copy Markdown
Author

@HassanOHOsman HassanOHOsman Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very smart of me.
Got rid of the variable tag altogether.


});
}

function _formatTimestamp(timestamp) {
Expand Down