NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend#77
Open
ZabihollahNamazi wants to merge 14 commits into
Open
NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend#77ZabihollahNamazi wants to merge 14 commits into
ZabihollahNamazi wants to merge 14 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author
cjyuan
reviewed
May 24, 2026
cjyuan
left a comment
There was a problem hiding this comment.
Code works on normal circumstances. My comments are mainly surrounding handling of
errors and unusual user input.
Can you also include these items in the PR description?
- A description of the additional features you have implemented
- A link to the deployed frontend on the CYF hosting environment
- A link to the deployed backend on the CYF hosting environment
cjyuan
reviewed
May 30, 2026
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. I have a few more comments.
Note: The deployed app is not the updated version.
|
Changes look good. Well done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
chat application using Express (backend) and JavaScript frontend. Users can send messages and view messages from all users in real time
frontend link:
https://zabihollah-namazi-chat-app-frontend.hosting.codeyourfuture.io/
backend link:
https://zabihollah-namazi-chat-app-backend.hosting.codeyourfuture.io/
thank you very much