Skip to content

NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend#77

Open
ZabihollahNamazi wants to merge 14 commits into
CodeYourFuture:mainfrom
ZabihollahNamazi:zabihollah-chat-app
Open

NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend#77
ZabihollahNamazi wants to merge 14 commits into
CodeYourFuture:mainfrom
ZabihollahNamazi:zabihollah-chat-app

Conversation

@ZabihollahNamazi
Copy link
Copy Markdown

@ZabihollahNamazi ZabihollahNamazi commented May 4, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

chat application using Express (backend) and JavaScript frontend. Users can send messages and view messages from all users in real time
frontend link:
https://zabihollah-namazi-chat-app-frontend.hosting.codeyourfuture.io/
backend link:
https://zabihollah-namazi-chat-app-backend.hosting.codeyourfuture.io/
thank you very much

@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Decomposition The name of the module. labels May 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 4, 2026
@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi changed the title Norht West | 26-SDC-Mar | Zabihollah Namazi | chat app North West | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | chat app May 4, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi changed the title North West | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | chat app NW | 2026-mar-sdc | Zabihollah Namazi | Module-Decomposition | Sprint 2 | chat-app May 4, 2026
@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 4, 2026
@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi changed the title NW | 2026-mar-sdc | Zabihollah Namazi | Module-Decomposition | Sprint 2 | chat-app Manchester | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend May 4, 2026
@github-actions

This comment has been minimized.

@ZabihollahNamazi ZabihollahNamazi changed the title Manchester | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | Chat App frontend May 4, 2026
@ZabihollahNamazi ZabihollahNamazi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 4, 2026
@ZabihollahNamazi
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works on normal circumstances. My comments are mainly surrounding handling of
errors and unusual user input.


Can you also include these items in the PR description?

  • A description of the additional features you have implemented
  • A link to the deployed frontend on the CYF hosting environment
  • A link to the deployed backend on the CYF hosting environment

Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/backend/server.js
Comment thread chat-app/backend/server.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
@ZabihollahNamazi ZabihollahNamazi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I have a few more comments.

Note: The deployed app is not the updated version.

Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/frontend/app.js Outdated
Comment thread chat-app/frontend/app.js
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@ZabihollahNamazi ZabihollahNamazi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 30, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Decomposition The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants