Sheffield | 26-ITP-Jan | Mona-Eltantawy | Sprint 3| Alarm clock by Mona-Eltantawy · Pull Request #1158 · CodeYourFuture/Module-Data-Groups

Mona-Eltantawy · 2026-04-01T21:17:14Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

… instead of number - in the js file i implemented functions to set the alarm to count the remaining time and play the alarm sound when it counts to 0 .

…ents

Luro91 · 2026-04-04T10:00:31Z

The html title should say "Alarm clock app"

I meant the title that is responsible for what is shown in the tab in the browser header. How can you change this?

yeah, I got your point and changed it

Luro91 · 2026-04-04T10:02:30Z

-function setAlarm() {}
+var audio = new Audio("alarmsound.mp3");

-// DO NOT EDIT BELOW HERE


I think your code should be above this line

I changed the whole page multiple times so I don't have the line now

Luro91 · 2026-04-04T10:04:22Z

+  if (isNaN(timeRemaining) || timeRemaining <= 0) {
+    alert("Please enter a valid number greater than 0");


Nice error handling. It's important to validate user input

I've changed the alert to console.error.
not sure if it's right or not.

I did not intent to request a change here. It was already good. The advantage of the alert is that it is more visible to the user. For the first exercises I think alerts and console.error logs are both fine.

Luro91 · 2026-04-04T10:08:30Z


 function pauseAlarm() {
  audio.pause();
+  audio.currentTime = 0;


Nice that you reset the audio time here

Luro91

Well done

illicitonion · 2026-05-04T19:15:31Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Mona-Eltantawy added 2 commits April 1, 2026 18:34

created a new brach and renamed the index html file to Alarmclockapp

d598894

in the html file I changed the input type for the alarmSet to minutes…

3eaa8c0

… instead of number - in the js file i implemented functions to set the alarm to count the remaining time and play the alarm sound when it counts to 0 .

Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 1, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 1, 2026

This comment has been minimized.

Sign in to view

edited js file

a204333

Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 1, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 1, 2026

Mona-Eltantawy added 2 commits April 1, 2026 22:35

re- editeed the HTMl to the berivuse version to match the PR requirem…

384a4dd

…ents

restore the todolist filles to the original status

7210f43

Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 3, 2026

Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 4, 2026

Luro91 reviewed Apr 4, 2026

View reviewed changes

Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 4, 2026

Mona-Eltantawy mentioned this pull request Apr 11, 2026

26-Jan-ITP l Data Group l Mona-Eltantawy Mona-Eltantawy/My-Coursework-Planner--fork#3

Open

Mona-Eltantawy added 2 commits April 14, 2026 21:58

changed the html file name

83beeba

reedited the functions

0e2fdf2

Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 14, 2026

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026

changed the title in the html file to Alarm Clock app

60ea681

Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026

Luro91 reviewed Apr 19, 2026

View reviewed changes

illicitonion closed this May 4, 2026

		if (isNaN(timeRemaining) \|\| timeRemaining <= 0) {
		alert("Please enter a valid number greater than 0");

Uh oh!

Conversation

Mona-Eltantawy commented Apr 1, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants