Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Quote Generator#1151
Open
mshayriyesaricicek wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Quote Generator#1151mshayriyesaricicek wants to merge 1 commit intoCodeYourFuture:mainfrom
mshayriyesaricicek wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
mshayriyesaricicek
added
Needs Review
jayshreehajgude2012
added
the
Review in progress
jayshreehajgude2012
left a comment
jayshreehajgude2012
left a comment
There was a problem hiding this comment.
Nice styling but use externally.
Java script file linked correctly.
DOM methods used correctly.
Resolve Error-quotes array missing.
| padding: 10px 20px; | ||
| font-size: 16px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
You can use external CSS file and link it to CSS to make code clean.
| font-size: 16px; | ||
| } | ||
| </style> | ||
| <script defer src="quotes.js"></script> |
There was a problem hiding this comment.
Correctly linked JavaScript file.
| @@ -1,3 +1,20 @@ | |||
| // DO NOT EDIT ABOVE HERE | |||
| window.addEventListener("DOMContentLoaded", () => { | |||
There was a problem hiding this comment.
You used DOMContentLoaded properly
Clean DOM selection
Good use of textContent
Proper event listener used.
You can explore more DOM selection and Event handling methods.
| const newQuoteBtn = document.getElementById("new-quote"); | ||
|
|
||
| function displayRandomQuote() { | ||
| const randomQuote = pickFromArray(quotes); |
There was a problem hiding this comment.
Quote Array is missing look into it.
jayshreehajgude2012
added
Reviewed
mshayriyesaricicek
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Added a function to enable random quotes to be generated by pressing the new quote buttons.
Added style to the page by updated HTML.