Skip to content

Manchester | ITP-Jan-26 | Khalidbih | Sprint 3 | Alarm Clock#1150

Open
khalidbih wants to merge 2 commits intoCodeYourFuture:mainfrom
khalidbih:Sprint-3/alarm-clock/Clean
Open

Manchester | ITP-Jan-26 | Khalidbih | Sprint 3 | Alarm Clock#1150
khalidbih wants to merge 2 commits intoCodeYourFuture:mainfrom
khalidbih:Sprint-3/alarm-clock/Clean

Conversation

@khalidbih
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Complete implementation of the alarm clock with countdown timer and sound alert.

@github-actions

This comment has been minimized.

@khalidbih khalidbih added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 30, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 30, 2026
@github-actions

This comment has been minimized.

@khalidbih khalidbih changed the title Manchester | ITP-Jan-26 | Khalidbih | Sprint-3 | Alarm Clock Manchester | ITP-Jan-26 | Khalidbih | Sprint 3 | Alarm Clock Mar 30, 2026
@khalidbih khalidbih added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 30, 2026
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 4, 2026
Copy link
Copy Markdown

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good attempt, however:

  1. The form field accepts negative numbers, It should not
  2. When the form field is empty and I click set alarm, the alarm sound goes off, the sound should not go off with an empty form field.

These are the things I observed and I think should be fixe, still good job!

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 4, 2026
@khalidbih
Copy link
Copy Markdown
Author

This is a good attempt, however:

  1. The form field accepts negative numbers, It should not
  2. When the form field is empty and I click set alarm, the alarm sound goes off, the sound should not go off with an empty form field.

These are the things I observed and I think should be fixe, still good job!

Thank you for the feedback! I've updated the alarm clock to prevent negative numbers and to ignore empty inputs.

@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants