Birmingham | Jan-ITP-2026 | Arunkumar Akilan | Sprint 3 | Alarm Clock#1096
Open
arunkumarakilan wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Birmingham | Jan-ITP-2026 | Arunkumar Akilan | Sprint 3 | Alarm Clock#1096arunkumarakilan wants to merge 3 commits intoCodeYourFuture:mainfrom
arunkumarakilan wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
arunkumarakilan
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
arunkumarakilan
added
the
Needs Review
jayshreehajgude2012
added
Review in progress
| let seconds = input.value%60; | ||
| let minutes = (input.value - seconds)/60; | ||
| const timeRemaining = document.querySelector("#timeRemaining"); | ||
| timeRemaining.textContent = `Time Remaining: ${minutes.toString().padStart(2, "0")}:${seconds.toString().padStart(2, "0")}`; |
There was a problem hiding this comment.
Can you helper function or any other technique to improve readability and reusability?
| let minutes = (input.value - seconds)/60; | ||
| const timeRemaining = document.querySelector("#timeRemaining"); | ||
| timeRemaining.textContent = `Time Remaining: ${minutes.toString().padStart(2, "0")}:${seconds.toString().padStart(2, "0")}`; | ||
| givenTime = Number(input.value); |
jayshreehajgude2012
left a comment
jayshreehajgude2012
left a comment
There was a problem hiding this comment.
improve readability and apply data validation to improve performance further.
jayshreehajgude2012
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions