Manchester | 26-ITP-Jan | Khalidbih | Sprint 2 | Data Groups#1092
Open
khalidbih wants to merge 16 commits intoCodeYourFuture:mainfrom
Open
Manchester | 26-ITP-Jan | Khalidbih | Sprint 2 | Data Groups#1092khalidbih wants to merge 16 commits intoCodeYourFuture:mainfrom
khalidbih wants to merge 16 commits intoCodeYourFuture:mainfrom
Conversation
khalidbih
added
📅 Sprint 2
cjyuan
reviewed
Mar 25, 2026
cjyuan
added
Reviewed
khalidbih
added
Needs Review
cjyuan
reviewed
Mar 27, 2026
Sprint-2/implement/querystring.js
Outdated
Comment on lines
+29
to
+31
| queryParams[decodedKey] = undefined; | ||
| } else { | ||
| queryParams[key] = decodeURIComponent(value); |
Contributor
There was a problem hiding this comment.
You changed only one of them.
Author
There was a problem hiding this comment.
I initially only fixed the line you pointed out. Thank you for catching that. I’ve now updated both to use the decoded key.
cjyuan
added
Complete
Author
Thank you so much for your feedback and suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist :
Changelist :
Implemented and fixed the Sprint-2 exercises with tests.