generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 275
Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Data group-coursework #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tasleemadedokun
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
tasleemadedokun:Data_group/coursework/sprint2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
55bda60
Fix the function to obtain the object information instead of an array.
tasleemadedokun e918edd
Effect new change to obtain object values.
tasleemadedokun 900386d
Fix the function to print the ingredients in new lines.
tasleemadedokun abbdf97
Add the function with the new tests to the function.
tasleemadedokun a6011d2
Effect changes to lookup.js and lookup.test.js
tasleemadedokun 85ddd3d
Implement changes.
tasleemadedokun b49a5ea
Write new function to tally.js and new test to tally.test.js
tasleemadedokun 70882b9
Remove the h
tasleemadedokun e347daa
Fix the code and implement the test function changes.
tasleemadedokun d1c1a3c
Use Array.prototype.join() to implement the change.
tasleemadedokun 12cbb33
Implement the cleaner and modern way version Object.hasOwn(obj, prop)
tasleemadedokun 40b62ea
Implement the changes.
tasleemadedokun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| function contains() {} | ||
| function contains(obj, prop) { | ||
| // Check that obj is an object (not null) and not an array | ||
| if (typeof obj !== "object" || obj === null || Array.isArray(obj)) { | ||
| return false; | ||
| } | ||
| // Check if the property exists directly on the object | ||
| return Object.hasOwn(obj, prop); | ||
| } | ||
|
|
||
|
|
||
| module.exports = contains; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,23 @@ | ||
| function createLookup() { | ||
|
|
||
| // implementation here | ||
| function createLookup(pairs) { | ||
|
|
||
| if (!Array.isArray(pairs)) { | ||
| throw new Error('Input must be an array of pairs'); | ||
| } | ||
|
|
||
| const lookup = {}; | ||
|
|
||
| for (const pair of pairs) { | ||
|
|
||
| if (!Array.isArray(pair) || pair.length !== 2) { | ||
| throw new Error('Each element must be an array of [countryCode, currencyCode]'); | ||
| } | ||
| const [country, currency] = pair; | ||
| lookup[country] = currency; | ||
| } | ||
|
|
||
| return lookup; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| function tally() {} | ||
| function tally(items) { | ||
| if (!Array.isArray(items)) { | ||
| throw new Error("Input must be an array"); | ||
| } | ||
|
|
||
| const result = Object.create(null); | ||
|
|
||
| for (const item of items) { | ||
| result[item] = (result[item] || 0) + 1; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| module.exports = tally; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| const invert = require('./invert'); | ||
| test("inverts a single key-value pair", () => { | ||
| expect(invert({ a: 1 })).toEqual({ 1: "a" }); | ||
| }); | ||
|
|
||
| test("inverts multiple key-value pairs", () => { | ||
| expect(invert({ a: 1, b: 2 })).toEqual({ 1: "a", 2: "b" }); | ||
| }); | ||
|
|
||
| test("handles string values", () => { | ||
| expect(invert({ x: "orange", y: "grape" })).toEqual({ | ||
| orange: "x", | ||
| grape: "y", | ||
| }); | ||
| }); | ||
|
|
||
| test("returns empty object when input is empty", () => { | ||
| expect(invert({})).toEqual({}); | ||
| }); | ||
|
|
||
| test("overwrites duplicate values (last key wins)", () => { | ||
| expect(invert({ a: 1, b: 1 })).toEqual({ 1: "b" }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.