London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062
London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062Oussama-Mouggal wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
There was a problem hiding this comment.
(1) Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.
Note: a user may not click the "Stop" button first before starting a new count down.
(2) When input is 1, the alarm is played one second later -- an expected behavior.
However, when input is 0, the alarm is also played one second later (instead of being played immediately).
Can you make the app's behaviour more consistent?
|
Thank you @cjyuan for your valuable feedback. I added a dedicated reset path for clean restarts and made 0-second input trigger the alarm immediately for consistent behavior. |
|
Changes look good. |
Self checklist
Changelist
I changed the title and added the alarm clock logic to the file as requested.