Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 3 | Quote generator#1060
Open
Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 3 | Quote generator#1060Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 27, 2026
Sprint-3/quote-generator/script.js
Outdated
| const randomQuote = pickFromArray(quotes); | ||
|
|
||
| quoteElement.textContent = randomQuote.quote; | ||
| authorElement.textContent = `- ${randomQuote.author}`; |
Contributor
There was a problem hiding this comment.
The leading - appears to be for styling purposes. Keeping it in the CSS or in HTML could allow us to adjust the view without changing any JavaScript code.
Sprint-3/quote-generator/script.js
Outdated
Comment on lines
+14
to
+16
| displayRandomQuote(); | ||
|
|
||
| buttonElement.addEventListener("click", displayRandomQuote); |
Contributor
There was a problem hiding this comment.
Placing all the "run on load" code in one place can make it clearer that
"this is what runs when the page loads."
For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
Sprint-3/quote-generator/script.js
Outdated
| if (autoPlayElement.checked) { | ||
| statusElement.textContent = "auto-play: ON"; | ||
|
|
||
| clearInterval(intervalId); |
Contributor
There was a problem hiding this comment.
Is it possible that the interval is active when the checkbox's state changes to "checked"?
cjyuan
added
Reviewed
Author
|
Thanks for the feedback! I’ve updated the code by:
|
Dan2Clouted
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
The quote generator app exercise completed.