Skip to content

Glasgow | JAN-ITP-2026 | Alasdair MacDonald | Sprint 3 | Quote Generator app #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MacDonald91 wants to merge 3 commits into from
Closed

Glasgow | JAN-ITP-2026 | Alasdair MacDonald | Sprint 3 | Quote Generator app #1035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cc51cd
complete build of quote generator app
MacDonald91 Mar 17, 2026
903eebe
fix: moved run load logic into a setup
MacDonald91 Apr 15, 2026
c1e0c51
Merge branch 'main' into coursework/quote-generator-app
MacDonald91 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<link rel="stylesheet" href="style.css">
<script defer src="quotes.js"></script>
</head>
<body>
Expand Down
15 changes: 15 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,18 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

function displayRandomQuote() {
const randomQuote = pickFromArray(quotes);

document.getElementById("quote").textContent = randomQuote.quote;
document.getElementById("author").textContent = randomQuote.author;
}

// run when page loads2
displayRandomQuote();

// button click
document
.getElementById("new-quote")
.addEventListener("click", displayRandomQuote);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put all the "run on load" code inside a function?
Doing so can make it clearer that "this is what runs when the page loads."
For examples,

function setup() {
  // code to be executed on page load
}

window.addEventListener('load', setup);

or

window.addEventListener('load', function() {
  // code to be executed on page load
});

Copy link
Copy Markdown
Author

@MacDonald91 MacDonald91 Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion!

I’ve moved all the “run on load” logic into a setup function and attached it to the window load event to make the structure clearer and easier to understand.

Let me know if there’s anything else I can improve.

36 changes: 36 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,37 @@
/** Write your CSS in here **/
body {
font-family: Arial, sans-serif;
background-color: #f4f4f4;
text-align: center;
padding: 50px;
}

h1 {
color: #333;
}

#quote {
font-size: 1.5rem;
margin: 20px 0;
color: #222;
}

#author {
font-size: 1.2rem;
color: #666;
margin-bottom: 30px;
}

button {
padding: 10px 20px;
font-size: 1rem;
background-color: #007BFF;
color: white;
border: none;
border-radius: 5px;
cursor: pointer;
}

button:hover {
background-color: #0056b3;
}
Loading