London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |Alarm Clock app by DamianDL · Pull Request #1028 · CodeYourFuture/Module-Data-Groups

DamianDL · 2026-03-17T10:17:32Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Updated code to :

Convert input of minutes and Seconds to Seconds,
Include dynamic countdown of timeRemaining
Set the alarm
Validate that input is numeric , finite and not null,
Countdown Alarm to zero. Play sound and change screen colour.

Questions

Please review for Data Groups module?

hkavalikas · 2026-03-22T11:48:28Z

There is a requirement to update the title of the page to Alarm clock app that was missed, let's address that.

hkavalikas · 2026-03-22T11:50:03Z

Sprint-3/alarmclock/alarmclock.js

Completely optional and can be personal preference but we might have over-commented some of the lines, some comments are genuinely useful and are great to document code but others might be consider self explanatory.

I think you're right about style- I have put most of the comments in as a reminder to myself when I look at it again- not very neat and collaborative, but useful for me while I'm learning and possibly reusing in future modules. If there's a better or more standard way of doing that, I'm happy to comply? Thanks

Hey @DamianDL , typically when we raise PRs, we would only keep comments for things that really aren't obvious from the code alone, like context or complicated implementation that would require that extra info (ideally the code self-documents what we are trying to do with proper variable and function names), but for learning purposes I don't feel too strongly against keeping them.

hkavalikas · 2026-03-22T11:51:35Z

Sprint-3/alarmclock/alarmclock.js

+      clearInterval(countdownId);
+      countdownId = null;
+      playAlarm();
+      document.body.style.backgroundColor = "red"; // change background colour


This is an awesome touch, minor point is that when the background becomes red, then a new timer could reset it back to the original background (until it's done counting and it goes back to red). How can we implement that?

Reset screen to white when timer set.

hkavalikas · 2026-03-22T11:53:22Z

Sprint-3/alarmclock/alarmclock.js

+}
+
+function setAlarm() {
+  const input = document.getElementById("alarmSet");// Get the input element using its DOM ID


Completely optional, can we add some guards against edge cases such as empty input, negative values, and (potentially) 0? Everything would trigger an alarm right away with the current implementation.

Updated edge cases of 0 and -1 to not accept inputs.

hkavalikas · 2026-03-24T19:39:17Z

Let's address the github action @DamianDL

DamianDL · 2026-03-25T11:38:18Z

Github action addressed- I hope. Passing script and I hope all changes to alarmclock.js retained. Thanks

hkavalikas · 2026-03-26T12:29:39Z

Sprint-3/alarmclock/alarmclock.js

+  // Clear the alarm timeout if it exists
+  if (alarmTimeoutId !== null) {
+    clearTimeout(alarmTimeoutId);
+    alarmTimeoutId = null;
+  }


Can you think of a way of doing this without editing below the DO NOT EDIT BELOW HERE line?

Moved to the checks line 36

hkavalikas · 2026-03-26T12:32:14Z

Sprint-3/alarmclock/alarmclock.js

+
+function updateHeading(totalSeconds) {
+  // Update the heading with the formatted time remaining
+  const heading = document.getElementById("timeRemaining"); // Get the heading element using its DOM ID


We are calling this function on every "tick", which grabs the heading from the DOM. How can we make sure the heading is only queried/selected once and reused instead?

Still an issue

Used a cache wrapper set getTimeRemainingHeading function line 5 and reuse line 21 function.

hkavalikas · 2026-03-26T12:33:35Z

We are also missing the page title Alarm clock app mentioned in the README.

…lacing in the guards line 33

hkavalikas · 2026-03-27T08:12:27Z

Sprint-3/alarmclock/alarmclock.js

@@ -1,4 +1,68 @@
-function setAlarm() {}
+let countdownId = null;
+let alarmTimeoutId = null; // Track the alarm timeout to clear it if needed


Where is this used?

Alarm Timeout Id removed from code

hkavalikas · 2026-03-27T08:13:11Z

Sprint-3/alarmclock/alarmclock.js

+
+function updateHeading(totalSeconds) {
+  // Update the heading with the formatted time remaining
+  const heading = document.getElementById("timeRemaining"); // Get the heading element using its DOM ID


Still an issue

hkavalikas · 2026-03-27T08:15:44Z

Some comments from yesterday weren't addressed including the page title.

…removal of alarmtimeoutID, which was not doing anything

hkavalikas · 2026-03-28T08:46:05Z

The title was reverted back again @DamianDL

Changes to Alarm Clock

7df742b

DamianDL added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. javascript Pull requests that update javascript code labels Mar 17, 2026

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026

hkavalikas self-requested a review March 22, 2026 11:47

hkavalikas suggested changes Mar 22, 2026

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 22, 2026

DamianDL added 2 commits March 24, 2026 16:00

updated alarmclock to set screen to white when alarm set

508a059

updated alarmclock to reject 0 and negative inputs

e24cff1

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 24, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026

This comment has been minimized.

Sign in to view

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026

DamianDL and others added 2 commits March 24, 2026 16:24

remoc-ved quote-generator\style.css added in error

e3a54b6

Merge branch 'main' into Sprint-3

bdd65f9

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026

cleaning up style.css filkes

4fd4b81

DamianDL added 2 commits March 25, 2026 11:26

reverting to cahes to before style.css added

99e8139

restoring changes to alarmclock.js

4ddc2eb

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 26, 2026

hkavalikas suggested changes Mar 26, 2026

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 26, 2026

DamianDL added 3 commits March 26, 2026 15:17

updating index.html as per Readme with title

39e4ac5

moving the clear alarm timeout from below line 61 (lines 81-84) and p…

57f5291

…lacing in the guards line 33

cleaning up branch

5af3ad4

DamianDL requested a review from hkavalikas March 26, 2026 15:48

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 26, 2026

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 27, 2026

hkavalikas suggested changes Mar 27, 2026

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 27, 2026

DamianDL added 2 commits March 27, 2026 11:53

update to title, using chached wrapper to store time remaining text, …

038c1c5

…removal of alarmtimeoutID, which was not doing anything

restoring quote-generator index.html

8c88fd0

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 27, 2026

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 28, 2026

update to title

78d5a6a

Uh oh!

Conversation

DamianDL commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

hkavalikas commented Mar 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hkavalikas commented Mar 24, 2026

Uh oh!

DamianDL commented Mar 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkavalikas commented Mar 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkavalikas commented Mar 27, 2026

Uh oh!

hkavalikas commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DamianDL commented Mar 17, 2026 •

edited

Loading