Skip to content

London | 26-ITP-January | Laura C | Sprint 3 | Alarm Clock#1022

Open
lauracs24 wants to merge 8 commits intoCodeYourFuture:mainfrom
lauracs24:sprint-3-alarmclock
Open

London | 26-ITP-January | Laura C | Sprint 3 | Alarm Clock#1022
lauracs24 wants to merge 8 commits intoCodeYourFuture:mainfrom
lauracs24:sprint-3-alarmclock

Conversation

@lauracs24
Copy link
Copy Markdown

@lauracs24 lauracs24 commented Mar 16, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implement

  • Updated the page title in index.html to Alarm clock app
  • Implemented the alarm countdown logic in alarmclock.js
  • Updated the countdown every second using a timer
  • Played the alarm sound when the timer reached `00:00

Testing

  • Ran the provided tests using npm test
  • Confirmed that all tests pass

@github-actions

This comment has been minimized.

Sign in to view
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026
@lauracs24 lauracs24 moved this to Awaiting Approval🚀 in Coursework Planner Mar 16, 2026
@hkavalikas hkavalikas self-requested a review March 22, 2026 11:35
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026
hkavalikas
hkavalikas suggested changes Mar 22, 2026
View reviewed changes
@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 22, 2026
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
hkavalikas
hkavalikas suggested changes Mar 26, 2026
View reviewed changes
Sprint-3/alarmclock/alarmclock.js
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if we add 1.5 in the timer? How can we fix it?

Copy link
Copy Markdown
Author

@lauracs24 lauracs24 Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this!

I’ve now updated the implementation to ensure the timer only uses whole seconds by converting the input to an integer and added validation to handle invalid inputs @hkavalikas

@hkavalikas hkavalikas removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 26, 2026
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 26, 2026
@lauracs24
Copy link
Copy Markdown
Author

lauracs24 commented Mar 26, 2026

Hi @hkavalikas. Can you please review my request?

@lauracs24 lauracs24 requested a review from hkavalikas March 26, 2026 14:28
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 27, 2026
@hkavalikas
Copy link
Copy Markdown

hkavalikas commented Mar 27, 2026

You might have missed this:
#1022 (comment)

@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 27, 2026
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 28, 2026
@hkavalikas
Copy link
Copy Markdown

hkavalikas commented Mar 28, 2026

Awesome work

@lauracs24 lauracs24 mentioned this pull request Mar 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkavalikas hkavalikas Awaiting requested review from hkavalikas

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lauracs24 @hkavalikas