Birmingham | 26 JAN ITP | Merve Reis | Sprint 1 | Data Groups#1021
Open
mervereis wants to merge 12 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26 JAN ITP | Merve Reis | Sprint 1 | Data Groups#1021mervereis wants to merge 12 commits intoCodeYourFuture:mainfrom
mervereis wants to merge 12 commits intoCodeYourFuture:mainfrom
Conversation
mervereis
added
📅 Sprint 1
mervereis
changed the title
cjyuan
reviewed
Mar 19, 2026
cjyuan
added
Reviewed
mervereis
added
the
Needs Review
cjyuan
reviewed
Mar 23, 2026
Sprint-1/fix/median.js
Outdated
Comment on lines
+27
to
+28
| // Copy before sort (extra safety, though filter already creates new array) | ||
| const sorted = [...numbers].sort((a, b) => a - b); |
Contributor
There was a problem hiding this comment.
Why do you need this "extra safety" to make a copy of numbers before sorting? Safety from what?
Contributor
There was a problem hiding this comment.
Why make a copy of numbers before sorting?
Author
There was a problem hiding this comment.
@cjyuan I reverted to spreading numbers before sorting, now just using numbers directly instead of creating a copy of it.
cjyuan
removed
the
Needs Review
mervereis
added
the
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Functions created as requested and test cases wroten for