Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Data Groups #1016
Open
libanj0161 wants to merge 15 commits intoCodeYourFuture:mainfrom
Open
Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Data Groups #1016libanj0161 wants to merge 15 commits intoCodeYourFuture:mainfrom
libanj0161 wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
libanj0161
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
libanj0161
changed the title
This comment has been minimized.
This comment has been minimized.
libanj0161
changed the title
This comment has been minimized.
This comment has been minimized.
libanj0161
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
libanj0161
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
libanj0161
added
📅 Sprint 1
libanj0161
added
the
Needs Review
cjyuan
reviewed
Mar 19, 2026
cjyuan
added
Reviewed
libanj0161
added
the
Needs Review
cjyuan
reviewed
Mar 28, 2026
Sprint-1/implement/max.test.js
Outdated
Comment on lines
+74
to
+81
| test("given an array including Nan return correct total", () => { | ||
| expect(findMax([11, NaN, 5])).toBe(11); | ||
| }); | ||
|
|
||
| // Given an array with numeric string value | ||
| // When passed to the max function | ||
| // Then it should ignore the numeric string and return correct total | ||
| test("given an array with numeric string value, it should ignore the numeric string and return correct total", () => { |
Contributor
There was a problem hiding this comment.
The description of the expected return value are not quite correct.
cjyuan
removed
the
Needs Review
libanj0161
added
the
Needs Review
cjyuan
reviewed
Mar 28, 2026
Comment on lines
+27
to
+31
| const input = ["a", "b", "c"]; | ||
| const result = dedupe(input); | ||
|
|
||
| expect(result).toEqual(input); | ||
| expect(result).not.toBe(input); |
Contributor
There was a problem hiding this comment.
There is a chance that, even though result has incorrect elements (for example, []),
the two tests could still pass. Can you figure out why, and then fix the tests accordingly?
Author
There was a problem hiding this comment.
Added .toHaveLength to ensure the returned array has the same number of elements as the original.
Contributor
There was a problem hiding this comment.
This is better but it is still not 100% bullet proof. What if result is ["a", "b", "x"]?
Contributor
There was a problem hiding this comment.
Can you update the test to ensure expected has the expected elements?
And optionally add another test to ensure input remains unchanged after the function call.
Author
There was a problem hiding this comment.
From my research .toEqual already ensures the returned array has the exact expected elements. I also added an additional test to verify that calling the function does not change the original array.
cjyuan
removed
the
Needs Review
libanj0161
added
the
Needs Review
cjyuan
removed
the
Needs Review
libanj0161
added
the
Needs Review
cjyuan
reviewed
Mar 28, 2026
|
|
||
| dedupe(input); | ||
|
|
||
| expect(input).toEqual(original); |
Contributor
There was a problem hiding this comment.
You could combine this with the previous test.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Fix under data groups module.
Questions
N/A.