Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Todo list app#1015
Open
Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Todo list app#1015Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Elisabeth-Matulian
added
the
Needs Review
cjyuan
reviewed
Mar 26, 2026
cjyuan
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
cjyuan
reviewed
Mar 26, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+136
to
+143
| test("Delete 2 Completed task", () => { | ||
| const todos = createMockTodos(); | ||
| const todosBeforeDeletion = createMockTodos(); | ||
| const lengthBeforeDeletion = todos.length; | ||
| Todos.deleteCompleted(todos); | ||
|
|
||
| expect(todos).toHaveLength(lengthBeforeDeletion - 2); | ||
| }); |
Contributor
There was a problem hiding this comment.
This is a good start.
You could also check if the remaining two elements are actually the non-completed tasks.
Well, the more comprehensive our unit tests are, the higher the quality of our software.
No change required in this exercise.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement todo list app
Questions
N/Q