Skip to content

London|25_SDC_November|Donara Blanc| Sprint 2| skip list#91

Open
donarbl wants to merge 1 commit intoCodeYourFuture:mainfrom
donarbl:sprint-2-skip-list
Open

London|25_SDC_November|Donara Blanc| Sprint 2| skip list#91
donarbl wants to merge 1 commit intoCodeYourFuture:mainfrom
donarbl:sprint-2-skip-list

Conversation

@donarbl
Copy link
Copy Markdown

@donarbl donarbl commented Jan 31, 2026

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • [x ] I have tested my changes
  • My changes follow the style guide

@donarbl donarbl added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jan 31, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Mar 1, 2026
Copy link
Copy Markdown

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add just in case a little bit more unit-tests cases? Otherwise solid work, thanks!

import random


class _Node:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good underscored naming, as it is internal implementation

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 1, 2026
update = [None] * (self.MAX_LEVEL + 1)
current = self.head

# 1) Search for position from top level down
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well organized commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Complexity The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants