Filter out stale requests #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PFvanBeerendonk
force-pushed
the
filter-out-stale-requests
branch
3 times, most recently
from
b21778f to
31c0293
Compare
knokko
requested changes
Aug 1, 2025
knokko
left a comment
knokko
left a comment
There was a problem hiding this comment.
I left some comments, most of which are minor.
PFvanBeerendonk
force-pushed
the
filter-out-stale-requests
branch
3 times, most recently
from
892743e to
2a0763b
Compare
PFvanBeerendonk
force-pushed
the
filter-out-stale-requests
branch
2 times, most recently
from
f108b3b to
407ad86
Compare
PFvanBeerendonk
force-pushed
the
filter-out-stale-requests
branch
3 times, most recently
from
215a020 to
fd19c88
Compare
when fetching multiple times in a short time, make binderApi mark requests as isStale Model and Store will ignore stale data Allow setting model/store.allowStale to bypass this behavior
PFvanBeerendonk
force-pushed
the
filter-out-stale-requests
branch
from
fd19c88 to
e3aaf65
Compare
knokko
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when fetching multiple times in a short time, make binderApi mark requests as isStale Model and Store will ignore stale data
Allow setting model/store.allowStale to bypass this behavior