Skip to content

Add differential evaluation of C#, PHP SDK #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djhahe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add differential evaluation of C#, PHP SDK #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff29a13
Add differential evaluation of C#, PHP SDK
Jun 26, 2022
7af8f50
update php sdk review
Jun 26, 2022
6ed7ca4
Update README.md
djhahe Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Casper C# checklist

## Required methods

| Method | Source | | Notes |
| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:|
| chain_get_block | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L241) | ✅ | |
| info_get_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L220) | ✅ | |
| account_put_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L205) | ✅ | |
| chain_get_state_root_hash | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L13) | ✅ | |
| state_get_account_info | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L101) | ✅ | |
| state_get_balance | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L188) | ✅ | |
| state_get_dictionary_item | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L352) | ✅ | |
| query_global_state | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L162) | ✅ | |


## Reviewer notes

The SKD is aligned with the SDK standard.
21 changes: 21 additions & 0 deletions Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Casper PHP checklist

## Required methods

| Method | Source | | Notes |
| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:|
| chain_get_block | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L111) | ✅ | Missing BlockIdentifier type Ets: 1hour |
| info_get_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L96) | ✅ | |
| account_put_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L76) | ✅ | |
| chain_get_state_root_hash | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L194) | ✅ | |
| state_get_account_info | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L204) | ✅ | |
| state_get_balance | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L222) | ✅ | |
| state_get_dictionary_item | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L329) | ✅ | |
| query_global_state | N/A | ❌ | Est: 4hours |


## Reviewer notes

There is a missing method: `query_global_state`. The estimated implementation time for the method is 4 hours.
The implementation for `chain_get_block` should be merged to single function and take `BlockIdentifier` param. The estimated update time for the method is 1 hour
Other methods and types are aligned with the SDK standard.