Add ConfirmationModal component and unified toast utility#954
Merged
mftee merged 1 commit intoJun 1, 2026
Conversation
Destructive actions (cancel shipment, reject bid, delete document) executed immediately on click with no confirmation. ConfirmationModal provides a reusable dialog with danger/warning/info variants, an async onConfirm handler with built-in loading state, and a clean backdrop overlay so accidental clicks no longer trigger irreversible actions. API feedback was inconsistent across the app: some mutations used browser alert(), others showed no feedback, and Sonner was only called in a few places. The toast utility wraps Sonner with preset methods (success, error, info, warning, apiError, promise) and a shared extractMessage helper that unwrites NestJS validation error arrays, giving the whole frontend a single import for user feedback. Closes CodeGirlsInc#899 Closes CodeGirlsInc#900
|
@harouns-ux is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@harouns-ux Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
mftee
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destructive actions (cancel shipment, reject bid, delete document) executed immediately on click with no confirmation. ConfirmationModal provides a reusable dialog with danger/warning/info variants, an async onConfirm handler with built-in loading state, and a backdrop overlay to prevent accidental irreversible actions.
API feedback was inconsistent across the app — some mutations used browser alert(), others had no feedback, and Sonner was only called in a few places. The toast utility wraps Sonner with preset methods (success, error, info, warning, apiError, promise) and a shared extractMessage helper that unwraps NestJS validation error arrays, giving the whole frontend a single import for user feedback.
Closes #899
Closes #900