Skip to content

[1070] Add img to organization #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dianawieczorek wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[1070] Add img to organization #1071

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fab3fbe
changed custom facebook metatags for organizations
dianawieczorek Sep 26, 2018
9bc6f2e
changes
dianawieczorek Sep 26, 2018
cf426b8
revert unnecessary changes
dianawieczorek Sep 26, 2018
5cb3f22
partially done, now waiting for backend part
dianawieczorek Sep 26, 2018
0e88cb4
changed name to property
dianawieczorek Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/app/organization/organization-details/organization-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<div class="container">
<div class="card bg-light mb-3 text-white">
Copy link
Member

@magul magul Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this change was to introduce solution, that will work without any changes when backend API will be developed. You can use loadDefaultImage the way how @juliaanholcer developed it for offerrs or suggest your own solution, but it should be already here, when backend will arrive.

Copy link
Contributor Author

@dianawieczorek dianawieczorek Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadDefaultImage is only for offer, should I make other function for organization?

<!--when backend is ready, change volontulo photo with "{{ organization.image }}"-->
<img class="card-img" src="/assets/img/banner/volontulo_baner.png" alt="{{ organization.name }}">
</div>
<h2>Organizacja</h2>
<dl class="row offset-md-1">
<dt class="col-md-1">Nazwa</dt>
Expand Down