Skip to content

Builder frontend semantic html#430

Merged
Michael-Dratch merged 29 commits into
mainfrom
builder-frontend-semantic-html
Apr 27, 2026
Merged

Builder frontend semantic html#430
Michael-Dratch merged 29 commits into
mainfrom
builder-frontend-semantic-html

Conversation

@earth-walker
Copy link
Copy Markdown
Collaborator

@earth-walker earth-walker commented Apr 27, 2026 •
edited
Loading

Use appropriate semantic HTML elements such as h1, h2, p, span, button, nav, main, section and article instead of generic elements such as div.

@earth-walker
replace div with button
6c71d5b
@earth-walker
change div to button
57ad4a5
@earth-walker
use article for project cards
81e512c
@earth-walker
use button instead of div for save button
514fc56
@earth-walker
use button instead of div for form output validation
d56b5a7
@earth-walker
use button instead of div for confirm and cancel buttons in modal
7e7ca54
@earth-walker
change div to button for add button in configure check modal
8cf8406
@earth-walker
change div to button for create new check button in checks list
ef533a0
@earth-walker
use main instead of div for homescreen wrapper
0e40863
@earth-walker
use fragment instead of div for projects list wrapper
910e9eb
@earth-walker
use main instead of div for screener wrapper
d8cde09
@earth-walker
use section instead of div for form and results sections in screener
b91d41b
@earth-walker
use article instead of div for eligibility result cards
544253d
@earth-walker
use main instead of div for 404 page wrapper
7b50533
@earth-walker
use h2 instead of div for edit screener modal title
9ae161a
@earth-walker
use h2 instead of div for screener deletion confirmation modal title
c9fd1de
@earth-walker
use h2 instead of div for confirmation modal title
6ab79e5
@earth-walker
use h2 instead of div for error modal title
716dfdb
@earth-walker
use button instead of div for error modal close button
4d19ca6
@earth-walker
use h1 instead of div for sign in page title
a7d4d6f
@earth-walker
use p instead of div for deletion modal explanation
9b5d393
@earth-walker
use p instead of div for confirmation modal explanation
4bbbba3
@earth-walker
use nav instead of div for nav bar wrapper
aca22be
@earth-walker
use nav instead of div for nav bar wrapper
e4fafbd
@earth-walker
use section instead of div for drawer contents and use h2 instead of …
df9e92a 
…div for drawer welcome message
@earth-walker
use ul and li instead of divs for list of errors in error modal
d2d5b67
@earth-walker
use button instead of div for sign up button
7c82374
@earth-walker
use span instead of div for nav bar title
1300cdd
@earth-walker
remove unnecessary fragment
52bddff
@earth-walker earth-walker linked an issue Apr 27, 2026 that may be closed by this pull request
Use semantic HTML in builder frontend #403
Closed
@earth-walker earth-walker self-assigned this Apr 27, 2026
@Michael-Dratch Michael-Dratch merged commit 522775e into main Apr 27, 2026
1 check failed
@Michael-Dratch Michael-Dratch deleted the builder-frontend-semantic-html branch April 27, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Michael-Dratch Michael-Dratch Michael-Dratch approved these changes

@prestoncabe prestoncabe Awaiting requested review from prestoncabe prestoncabe is a code owner

@Justin-MacIntosh Justin-MacIntosh Awaiting requested review from Justin-MacIntosh

Assignees

@earth-walker earth-walker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use semantic HTML in builder frontend

2 participants

@earth-walker @Michael-Dratch