Remove enum from team packet so that invalid values don't throw ArrayIndexOutOfBoundsException #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IndexOutOfBoundsException. This will actually make it most like how BungeeCord handles it.
Owner
|
I'm not a fan of this PR. It reduces readability of the code. Robust parsing could also be achieved with a more local modification, checking the value of the parsed byte before indexing into the I assume this PR isn't relevant anymore since the root cause of the issue, the wrong packet id, has been fixed. |
Contributor
Author
|
Yeah not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will actually make it most like how BungeeCord handles it.