Add Velocity Support #766

proferabg · 2025-02-15T20:03:07Z

No description provided.

…d make Velocity build with JDK 17

Andre601

A few points I want to give my personal input towards.

One main thing that should be done, but that I didn't want to mention on every single file, is to update the copyright header for every added and changed file to have 2025 as the year, since this was the year those files where added/changed and where the copyright becomes effective.

Andre601 · 2025-02-15T20:11:33Z

.github/workflows/build.yml


-      - name: Set up JDK 16
+      - name: Set up JDK 17
        uses: actions/setup-java@v2


While probably not necessary, it could be good to update this to v4, because... why should it stay on v2?

This can be changed if we want to use v4. Left it at v2 to minimize changes

Andre601 · 2025-02-15T20:15:18Z

bootstrap-velocity/src/main/java/codecrafter47/bungeetablistplus/BootstrapPlugin.java

+                player.disconnect(Component.text(NO_RELOAD_PLAYERS));
+            }
+        }
+        getProxy().getPluginManager().getPlugin("BungeeTabListPlus");


What particular reason has this method call? Isn't that redundant, or does it force Velocity to perform some necessary background tasks?

This was probably part of old code that I didn't fully remove. I removed it in the latest commit

Andre601 · 2025-02-15T20:16:19Z

bootstrap-velocity/src/main/java/codecrafter47/bungeetablistplus/BootstrapPlugin.java

+        BungeeTabListPlus.getInstance(this).onLoad();
+        BungeeTabListPlus.getInstance(this).onEnable();
+        // Metrics
+        metricsFactory.make(this, 4332);


Probably needs updating of the ID, given Velocity and BungeeCord are treated as separate environments on bStats and this would only cause confusion.
Leaving this as a note for CodeCrafter.

There will most definitely need to be a new metric ID created for Velocity

I have created a new id: 24808.

Andre601 · 2025-02-15T20:16:50Z

bootstrap-velocity/src/main/java/codecrafter47/bungeetablistplus/BootstrapPlugin.java

+    public void onProxyShutdown(final ProxyShutdownEvent event) {
+        BungeeTabListPlus.getInstance().onDisable();
+        if (!getProxy().isShuttingDown()) {
+            getLogger().error("You cannot use ServerUtils to reload BungeeTabListPlus. Use /btlp reload instead.");


ServerUtils?

ServerUtils is the only Velocity plugin for reloading plugins, kinda like PlugMan. This can be genericized in case of other plugins existing.

Andre601 · 2025-02-15T20:24:32Z

velocity/src/main/java/codecrafter47/bungeetablistplus/util/chat/ChatUtil.java

I'm mixed feelings on this utility.

I see the BBCode style aproach as kind of pointless, because Velocity exposes Adventure and MiniMessage, already providing a String-based parsing for rich text.
At most could this perhaps be useful for parsing legacy colors before sending everything through the MM parsing itself.

I also think that the use of such large regex patterns is a bit excessive and could probably cause performance issues? Was that properly tested already?

This code is copied from here which the Bungee version of the plugin uses but the Velocity version cannot use because of it using BungeeCord components as return values.

From what I can see the use is mostly internal?
In such a case could it probs be easier to utilize the pre-existing MiniMessage system embedded into Velocity.

Tho, in the end is there not much of a problem here to have this.

I wanted to keep it most like the existing BungeeTabListPlus formatting in that someone could take a config and use it on both sides (minus the luckperms permission providers)

proferabg · 2025-02-16T03:33:55Z

A few points I want to give my personal input towards.

One main thing that should be done, but that I didn't want to mention on every single file, is to update the copyright header for every added and changed file to have 2025 as the year, since this was the year those files where added/changed and where the copyright becomes effective.

Who should I copyright on this because it certainly wasn't Florian that ported it. Should I copyright with my own name or is there a project setup so that BungeeTabListPlus can be copywritten in itself?

Andre601 · 2025-02-16T12:37:05Z

Who should I copyright on this because it certainly wasn't Florian that ported it. Should I copyright with my own name or is there a project setup so that BungeeTabListPlus can be copywritten in itself?

It should work having both.
Like

Copyright (c) (your name)
Copyright (c) (btlp dev)

Saw this within other projects.

CodeCrafter47 · 2025-02-16T12:42:45Z

Personally, I find the copyright notices a bit annoying to keep up-to-date. If you want, then you can update them, but I would also be fine merging this as is. Adding your own name, as Andre601 suggests, is fine.

Andre601 · 2025-02-16T12:50:52Z

I was told copyright really is only necessary to update for files that get updated.

At least the newly sdded files should use 2025, as they didn't exis before, no?

proferabg · 2025-02-16T23:34:34Z

Copyrights have been updated, the metrics have changed to the new ID for velocity, and I adjusted the Team packet to use an enumeration for modes as well as cleaned up some of the map initializers.

CodeCrafter47 · 2025-02-22T09:28:32Z

Is this good to be merged from your side?

proferabg · 2025-02-23T02:00:32Z

Is this good to be merged from your side?

As long as there are nothing else needing changed and we are good on all the questions, then this can be merged.

CodeCrafter47 · 2025-03-09T09:33:37Z

It's merged now. Sorry this took so long.

proferabg and others added 22 commits January 2, 2023 20:51

Velocity somewhat working (ALPHA) release

12e5227

Remove Un-ported Example

22fc3a9

Remove Waterfall-Compat dependency

7aa6e6b

Move ChatUtil and add in unicode.txt

501394d

Fix some formatting and refactoring

8b6be73

Fix Redis Server ID

404e0f9

Fix Packet Listener and target java 11 like Velocity

62590b4

Remove SortingRuleAliasProcessor + Add Team Packet Registration

0f1839c

Remove deprecated API functions

3bbc797

Fix Compile Errors

f52e89b

Merge remote-tracking branch 'origin-original/dev' into dev

5258dad

Update Velocity to 1.20.1

1833ee5

Update minecraft-data-api version

d117a13

Update Submodules

f1ba70d

Merge remote-tracking branch 'upstream/master' into dev

74f91a0

Updated but not tested

326b399

Working? Seriously?

d1b686d

Fix github workflow

5d8e941

Make all projects build with JDK 8, make Bungee build with JDK 16, an…

10d61aa

…d make Velocity build with JDK 17

Make Velocity build without jar library

52618b0

Update submodule

f8e469b

Update Submodules

766a309

Andre601 reviewed Feb 15, 2025

View reviewed changes

Remove check for plugin.

17d6326

proferabg force-pushed the dev branch from abdd8eb to 87871a1 Compare February 16, 2025 23:32

Copyrights, Velocity Metrics, and Team Packet Mode Enum

0486694

proferabg force-pushed the dev branch from 87871a1 to 0486694 Compare February 16, 2025 23:33

CodeCrafter47 merged commit 5e650c8 into CodeCrafter47:master Mar 9, 2025

Kowagirl mentioned this pull request Mar 26, 2025

fix(velocity): cancel modified packets #768

Merged

Add Velocity Support #766

Add Velocity Support #766

Uh oh!

Conversation

proferabg commented Feb 15, 2025

Uh oh!

Andre601 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

proferabg Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

proferabg Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

proferabg commented Feb 16, 2025

Uh oh!

Andre601 commented Feb 16, 2025

Uh oh!

CodeCrafter47 commented Feb 16, 2025

Uh oh!

Andre601 commented Feb 16, 2025

Uh oh!

proferabg commented Feb 16, 2025

Uh oh!

CodeCrafter47 commented Feb 22, 2025

Uh oh!

proferabg commented Feb 23, 2025

Uh oh!

CodeCrafter47 commented Mar 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

proferabg Feb 16, 2025 •

edited

Loading

proferabg Feb 16, 2025 •

edited

Loading