mctp-estack: Consider MCTP transport header separately from the mtu#52
Open
SafetyInObscurity wants to merge 1 commit into
Open
mctp-estack: Consider MCTP transport header separately from the mtu#52SafetyInObscurity wants to merge 1 commit into
SafetyInObscurity wants to merge 1 commit into
Conversation
SafetyInObscurity
changed the title
SafetyInObscurity
force-pushed
the
mtu
branch
9 times, most recently
from
ed50a51 to
19c75f3
Compare
…n the Fragmenter The minimum payload for a non-eom MCTP packet is 64 bytes. Currently the Fragmenter considers MCTP transport headers as part of the mtu. This means the minimum mtu creates packets with 60 bytes of payload, less than the minimum. To fix this, the mtu now sets the maximum payload bytes, and the header is prepended. All packets returned by the fragmenter will now be four bytes longer. This needs to be accommodated by the size of input buffers and the expected length of packets. Signed-off-by: James Lee <james@codeconstruct.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum payload for a non-eom MCTP packet is 64 bytes. Currently the Fragmenter considers MCTP transport headers as part of the mtu. This means the minimum mtu creates packets with 60 bytes of payload, less than the minimum. To fix this, the mtu now sets the maximum payload bytes, and the header is prepended.
All packets returned by the fragmenter will now be four bytes longer. This needs to be accommodated by the size of input buffers and the expected length of packets.