mctp-estack: Add async feature gate, add blocking serial transport binding
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should the |
mkj
reviewed
Oct 30, 2025
Member
mkj
left a comment
mkj
left a comment
There was a problem hiding this comment.
I think async makes sense as a default feature. If Router isn't being used then I don't think it would have any binary overhead, just some extra built dependencies for embassy-sync's dep tree.
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com> Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com> Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com> Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com> Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: jonas loeffelholz <jonas.loeffelholz@9elements.com> Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
Signed-off-by: Marvin Gudel <marvin.gudel@9elements.com>
embediver
force-pushed
the
sync-features
branch
from
1acfd4c to
fafe92f
Compare
Contributor
Author
|
Rebased and updated as requested. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts async functionality and dependencies behind
asyncfeature gate.The serial transport binding was extended by blocking functionality using
embedded-io.