Skip to content

Code Review #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mckaragoz merged 4 commits into from
Mar 29, 2026
Merged

Code Review #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ea3e88
Reviewed Credential Client API
mckaragoz Mar 28, 2026
9056fdf
Reviewed Authorization Client API
mckaragoz Mar 28, 2026
bbd10f4
Reviewed Flow Client API
mckaragoz Mar 28, 2026
3ca3c6e
Reviewed User Client API
mckaragoz Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ app.MapRazorComponents<App>()
```

### 4) Add UAuth Script
Place this in `App.razor` or `index.html`
Place this in `App.razor` or `index.html` in your Blazor client application:
```csharp
<script src="_content/CodeBeam.UltimateAuth.Client.Blazor/uauth.min.js"></script>
```
Expand Down Expand Up @@ -281,7 +281,7 @@ LogoutAll But Keep Current Device

private async Task LogoutOthersAsync()
{
var result = await UAuthClient.Flows.LogoutOtherDevicesSelfAsync();
var result = await UAuthClient.Flows.LogoutMyOtherDevicesAsync();
Console.WriteLine(result.IsSuccess);
}
```
Expand Down
4 changes: 2 additions & 2 deletions ...m.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/AccountStatusDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ You can still active your account later.
return;
}

ChangeUserStatusSelfRequest request = new() { NewStatus = SelfUserStatus.SelfSuspended };
var result = await UAuthClient.Users.ChangeStatusSelfAsync(request);
ChangeUserStatusSelfRequest request = new() { NewStatus = SelfAssignableUserStatus.SelfSuspended };
var result = await UAuthClient.Users.ChangeMyStatusAsync(request);
if (result.IsSuccess)
{
Snackbar.Add("Your account suspended successfully.", Severity.Success);
Expand Down
2 changes: 1 addition & 1 deletion ...Beam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/CreateUserDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private async Task CreateUserAsync()
Password = _password
};

var result = await UAuthClient.Users.CreateAdminAsync(request);
var result = await UAuthClient.Users.CreateAsAdminAsync(request);

if (!result.IsSuccess)
{
Expand Down
2 changes: 1 addition & 1 deletion ...Beam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/CredentialDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ private async Task ChangePasswordAsync()
}
else
{
result = await UAuthClient.Credentials.ChangeCredentialAsync(UserKey.Value, request);
result = await UAuthClient.Credentials.ChangeUserAsync(UserKey.Value, request);
}

if (result.IsSuccess)
Expand Down
64 changes: 32 additions & 32 deletions ...Beam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/IdentifierDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protected override async Task OnAfterRenderAsync(bool firstRender)

if (firstRender)
{
var result = await UAuthClient.Identifiers.GetMyIdentifiersAsync();
var result = await UAuthClient.Identifiers.GetMyAsync();
if (result != null && result.IsSuccess && result.Value != null)
{
await ReloadAsync();
Expand All @@ -56,11 +56,11 @@ private async Task<GridData<UserIdentifierInfo>> LoadServerData(GridState<UserId

if (UserKey is null)
{
res = await UAuthClient.Identifiers.GetMyIdentifiersAsync(req);
res = await UAuthClient.Identifiers.GetMyAsync(req);
}
else
{
res = await UAuthClient.Identifiers.GetUserIdentifiersAsync(UserKey.Value, req);
res = await UAuthClient.Identifiers.GetUserAsync(UserKey.Value, req);
}

if (!res.IsSuccess || res.Value is null)
Expand Down Expand Up @@ -126,20 +126,20 @@ private async Task<DataGridEditFormAction> CommittedItemChanges(UserIdentifierIn

if (UserKey is null)
{
result = await UAuthClient.Identifiers.UpdateSelfAsync(updateRequest);
result = await UAuthClient.Identifiers.UpdateMyAsync(updateRequest);
}
else
{
result = await UAuthClient.Identifiers.UpdateAdminAsync(UserKey.Value, updateRequest);
result = await UAuthClient.Identifiers.UpdateUserAsync(UserKey.Value, updateRequest);
}

if (result.IsSuccess)
{
Snackbar.Add("Identifier updated successfully", Severity.Success);
Snackbar.Add("Identifier updated successfully.", Severity.Success);
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to update identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to update identifier.", Severity.Error);
}

await ReloadAsync();
Expand All @@ -165,29 +165,29 @@ private async Task AddNewIdentifier()

if (UserKey is null)
{
result = await UAuthClient.Identifiers.AddSelfAsync(request);
result = await UAuthClient.Identifiers.AddMyAsync(request);
}
else
{
result = await UAuthClient.Identifiers.AddAdminAsync(UserKey.Value, request);
result = await UAuthClient.Identifiers.AddUserAsync(UserKey.Value, request);
}

if (result.IsSuccess)
{
Snackbar.Add("Identifier added successfully", Severity.Success);
Snackbar.Add("Identifier added successfully.", Severity.Success);
await ReloadAsync();
StateHasChanged();
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to add identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to add identifier.", Severity.Error);
}
}

private async Task VerifyAsync(Guid id)
{
var demoInfo = await DialogService.ShowMessageBoxAsync(
title: "Demo verification",
title: "Demo Verification",
markupMessage: (MarkupString)
"""
This is a <b>demo</b> action.<br/><br/>
Expand All @@ -203,105 +203,105 @@ This will only mark the identifier as verified in UltimateAuth.
return;
}

VerifyUserIdentifierRequest request = new() { IdentifierId = id };
VerifyUserIdentifierRequest request = new() { Id = id };
UAuthResult result;

if (UserKey is null)
{
result = await UAuthClient.Identifiers.VerifySelfAsync(request);
result = await UAuthClient.Identifiers.VerifyMyAsync(request);
}
else
{
result = await UAuthClient.Identifiers.VerifyAdminAsync(UserKey.Value, request);
result = await UAuthClient.Identifiers.VerifyUserAsync(UserKey.Value, request);
}

if (result.IsSuccess)
{
Snackbar.Add("Identifier verified successfully", Severity.Success);
Snackbar.Add("Identifier verified successfully.", Severity.Success);
await ReloadAsync();
StateHasChanged();
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to verify primary identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to verify primary identifier.", Severity.Error);
}
}

private async Task SetPrimaryAsync(Guid id)
{
SetPrimaryUserIdentifierRequest request = new() { IdentifierId = id };
SetPrimaryUserIdentifierRequest request = new() { Id = id };
UAuthResult result;

if (UserKey is null)
{
result = await UAuthClient.Identifiers.SetPrimarySelfAsync(request);
result = await UAuthClient.Identifiers.SetMyPrimaryAsync(request);
}
else
{
result = await UAuthClient.Identifiers.SetPrimaryAdminAsync(UserKey.Value, request);
result = await UAuthClient.Identifiers.SetUserPrimaryAsync(UserKey.Value, request);
}

if (result.IsSuccess)
{
Snackbar.Add("Primary identifier set successfully", Severity.Success);
Snackbar.Add("Primary identifier set successfully.", Severity.Success);
await ReloadAsync();
StateHasChanged();
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to set primary identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to set primary identifier.", Severity.Error);
}
}

private async Task UnsetPrimaryAsync(Guid id)
{
UnsetPrimaryUserIdentifierRequest request = new() { IdentifierId = id };
UnsetPrimaryUserIdentifierRequest request = new() { Id = id };
UAuthResult result;

if (UserKey is null)
{
result = await UAuthClient.Identifiers.UnsetPrimarySelfAsync(request);
result = await UAuthClient.Identifiers.UnsetMyPrimaryAsync(request);
}
else
{
result = await UAuthClient.Identifiers.UnsetPrimaryAdminAsync(UserKey.Value, request);
result = await UAuthClient.Identifiers.UnsetUserPrimaryAsync(UserKey.Value, request);
}

if (result.IsSuccess)
{
Snackbar.Add("Primary identifier unset successfully", Severity.Success);
Snackbar.Add("Primary identifier unset successfully.", Severity.Success);
await ReloadAsync();
StateHasChanged();
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to unset primary identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to unset primary identifier.", Severity.Error);
}
}

private async Task DeleteIdentifier(Guid id)
{
DeleteUserIdentifierRequest request = new() { IdentifierId = id };
DeleteUserIdentifierRequest request = new() { Id = id };
UAuthResult result;

if (UserKey is null)
{
result = await UAuthClient.Identifiers.DeleteSelfAsync(request);
result = await UAuthClient.Identifiers.DeleteMyAsync(request);
}
else
{
result = await UAuthClient.Identifiers.DeleteAdminAsync(UserKey.Value, request);
result = await UAuthClient.Identifiers.DeleteUserAsync(UserKey.Value, request);
}

if (result.IsSuccess)
{
Snackbar.Add("Identifier deleted successfully", Severity.Success);
Snackbar.Add("Identifier deleted successfully.", Severity.Success);
await ReloadAsync();
StateHasChanged();
}
else
{
Snackbar.Add(result?.ErrorText ?? "Failed to delete identifier", Severity.Error);
Snackbar.Add(result?.ErrorText ?? "Failed to delete identifier.", Severity.Error);
}
}

Expand Down
5 changes: 3 additions & 2 deletions ...Beam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/PermissionDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,13 @@ private async Task Save()
{
var permissions = _groups.SelectMany(g => g.Items).Where(x => x.Selected).Select(x => Permission.From(x.Value)).ToList();

var req = new SetPermissionsRequest
var req = new SetRolePermissionsRequest
{
RoleId = Role.Id,
Permissions = permissions
};

var result = await UAuthClient.Authorization.SetPermissionsAsync(Role.Id, req);
var result = await UAuthClient.Authorization.SetRolePermissionsAsync(req);

if (!result.IsSuccess)
{
Expand Down
4 changes: 2 additions & 2 deletions ...odeBeam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/ProfileDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ protected override async Task OnInitializedAsync()
}
else
{
result = await UAuthClient.Users.GetProfileAsync(UserKey.Value);
result = await UAuthClient.Users.GetUserAsync(UserKey.Value);
}

if (result.IsSuccess && result.Value is not null)
Expand Down Expand Up @@ -96,7 +96,7 @@ private async Task SaveAsync()
}
else
{
result = await UAuthClient.Users.UpdateProfileAsync(UserKey.Value, request);
result = await UAuthClient.Users.UpdateUserAsync(UserKey.Value, request);
}

if (result.IsSuccess)
Expand Down
2 changes: 1 addition & 1 deletion .../CodeBeam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/ResetDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public partial class ResetDialog

private async Task RequestResetAsync()
{
var request = new BeginCredentialResetRequest
var request = new BeginResetCredentialRequest
{
CredentialType = CredentialType.Password,
ResetCodeType = ResetCodeType.Code,
Expand Down
7 changes: 4 additions & 3 deletions ...r/CodeBeam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/RoleDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ private async Task<DataGridEditFormAction> CommittedItemChanges(RoleInfo role)
{
var req = new RenameRoleRequest
{
Id = role.Id,
Name = role.Name
};

var result = await UAuthClient.Authorization.RenameRoleAsync(role.Id, req);
var result = await UAuthClient.Authorization.RenameRoleAsync(req);

if (result.IsSuccess)
{
Expand Down Expand Up @@ -109,8 +110,8 @@ private async Task DeleteRole(RoleId roleId)
if (confirm != true)
return;

var req = new DeleteRoleRequest();
var result = await UAuthClient.Authorization.DeleteRoleAsync(roleId, req);
var req = new DeleteRoleRequest() { Id = roleId };
var result = await UAuthClient.Authorization.DeleteRoleAsync(req);

if (result.IsSuccess)
{
Expand Down
10 changes: 5 additions & 5 deletions ...odeBeam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/SessionDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ private async Task LogoutAllAsync()

if (UserKey is null)
{
result = await UAuthClient.Flows.LogoutAllDevicesSelfAsync();
result = await UAuthClient.Flows.LogoutAllMyDevicesAsync();
}
else
{
result = await UAuthClient.Flows.LogoutAllDevicesAdminAsync(UserKey.Value);
result = await UAuthClient.Flows.LogoutAllUserDevicesAsync(UserKey.Value);
}

if (result.IsSuccess)
Expand All @@ -139,7 +139,7 @@ private async Task LogoutAllAsync()

private async Task LogoutOthersAsync()
{
var result = await UAuthClient.Flows.LogoutOtherDevicesSelfAsync();
var result = await UAuthClient.Flows.LogoutMyOtherDevicesAsync();

if (result.IsSuccess)
{
Expand All @@ -158,11 +158,11 @@ private async Task LogoutDeviceAsync(SessionChainId chainId)

if (UserKey is null)
{
result = await UAuthClient.Flows.LogoutDeviceSelfAsync(request);
result = await UAuthClient.Flows.LogoutMyDeviceAsync(request);
}
else
{
result = await UAuthClient.Flows.LogoutDeviceAdminAsync(UserKey.Value, request);
result = await UAuthClient.Flows.LogoutUserDeviceAsync(UserKey.Value, request);
}

if (result.IsSuccess)
Expand Down
4 changes: 2 additions & 2 deletions ...odeBeam.UltimateAuth.Sample.BlazorServer.EFCore/Components/Dialogs/UserDetailDialog.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
<MudText Typo="Typo.subtitle2">Status</MudText>
<MudChip T="string" Color="@GetStatusColor(_user?.Status)" Variant="Variant.Filled">@_user?.Status</MudChip>
<MudStack Row="true" AlignItems="AlignItems.Center" Spacing="2">
<MudSelect T="UserStatus" @bind-Value="_status" Dense="true" Variant="Variant.Outlined">
@foreach (var s in Enum.GetValues<UserStatus>())
<MudSelect T="AdminAssignableUserStatus" @bind-Value="_status" Dense="true" Variant="Variant.Outlined">
@foreach (var s in Enum.GetValues<AdminAssignableUserStatus>())
{
<MudSelectItem Value="@s">@s</MudSelectItem>
}
Expand Down
Loading
Loading