Image view #38
Open
Image view #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set and dynamically size accordingly. Selected image now stands out by maintaining expanded circle while selected
…moved giving a perceived delay to the user. The zoom should be instantaneous the moment the user clicks instead of having to wait to move the mouse before seeing the effect.
- Currently the onMouseMove triggers after the onClick event toggles a state that allows onMouseMove to activate.
- Refactoring to have the zoom enabled onClick instead of onMouseMove
- Placed ternary condition on the onMouseMove to enable zoom only if zoomify state is true.
- Onclick on the image toggles the zoomify state, but also either sets the zoom or resets the image to default based on the state.
- This enables instant zoom on click from default with subsequent immediate activation of the onMouseMove so user gets an immediate zoom and can track the image as well.
…ze state. Refactoring to split style and size states to two separate states. Refactored, functions preserved. Refactored quantity selector inside of AddToCart.jsx and sizeReducer.js. Quantity array now capped at 15 so max quantity selectable is 15. Added a rudimentary alert. Not dynamic.
…Began to implement svg components to declutter code.
… refactor later for modularity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.