🛡️ Sentinel: [CRITICAL] Fix command injection in unix system utilities#70
Conversation
Replaces vulnerable `execSync` calls that use string interpolation with `execFileSync` to pass user-provided arguments safely via an array without shell execution. This mitigates command injection risks. Changes applied to: - `packages/core/src/unix/id-lookups.ts` - `packages/core/src/unix/user-manager.ts` - `packages/core/src/unix/user-manager.test.ts` (Mock updates) Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command Injection. The application used
execSyncwith string interpolation for looking up user and group IDs and checking user existence (getGidFromGroupName,getUidFromUsername,getHomedirFromUsername, andunixUserExists). Malicious inputs could break out of double quotes and execute arbitrary shell commands.🎯 Impact: A malicious user could potentially gain Remote Code Execution (RCE) privileges on the host system or daemon environment.
🔧 Fix: Replaced
execSyncwithexecFileSyncto execute the binaries directly without spawning a shell (/bin/sh). Injected user variables are now passed safely inside the arguments array, using the--flag terminator to additionally protect against argument injection vulnerabilities.✅ Verification:
pnpm lintwithout regressions.pnpm test(specificallypnpm --filter @agor/core test -- src/unix/) and confirmed all mock expectations matched the newexecFileSyncimplementations, and that overall test suites passed correctly.PR created automatically by Jules for task 14930101047231501571 started by @Donach