Skip to content

⚡ Bolt: [performance improvement] Hoist loadConfig to prevent O(N) disk I/O in bulk worktree creation#67

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-fix-worktrees-loadconfig-16661565703369552395
Open

⚡ Bolt: [performance improvement] Hoist loadConfig to prevent O(N) disk I/O in bulk worktree creation#67
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt-fix-worktrees-loadconfig-16661565703369552395

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 31, 2026

💡 What:
Modified WorktreesService.create to call loadConfig() exactly once when processing an array of worktrees, instead of fetching it individually for every item inside a Promise.all loop. applyWorktreeCreateDefaults was updated to accept the config synchronously.

🎯 Why:
loadConfig() performs file reading and YAML parsing from the disk on every single invocation. When creating multiple worktrees in bulk, calling this method within a loop creates a severe O(N) disk I/O bottleneck, heavily blocking the Node.js event loop and slowing down execution significantly.

📊 Impact:
Reduces the disk I/O and latency of bulk worktree creation operations from O(N) to O(1). This completely eliminates the unnecessary synchronous/asynchronous file reads during iteration and improves overall system throughput.

🔬 Measurement:
Run pnpm test and pnpm lint and inspect apps/agor-daemon/src/services/worktrees.ts to ensure that loadConfig executes once outside the loop.


PR created automatically by Jules for task 16661565703369552395 started by @Donach

- Hoists `loadConfig()` call outside of the array mapping loop in `WorktreesService.create`.
- Modifies `applyWorktreeCreateDefaults` to accept the preloaded `config` argument.
- Changes `applyWorktreeCreateDefaults` from async to sync to streamline array mapping logic.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant