⚡ Bolt: [performance improvement] Hoist loadConfig to prevent O(N) disk I/O in bulk worktree creation#67
Conversation
- Hoists `loadConfig()` call outside of the array mapping loop in `WorktreesService.create`. - Modifies `applyWorktreeCreateDefaults` to accept the preloaded `config` argument. - Changes `applyWorktreeCreateDefaults` from async to sync to streamline array mapping logic. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Modified
WorktreesService.createto callloadConfig()exactly once when processing an array of worktrees, instead of fetching it individually for every item inside aPromise.allloop.applyWorktreeCreateDefaultswas updated to accept the config synchronously.🎯 Why:
loadConfig()performs file reading and YAML parsing from the disk on every single invocation. When creating multiple worktrees in bulk, calling this method within a loop creates a severe O(N) disk I/O bottleneck, heavily blocking the Node.js event loop and slowing down execution significantly.📊 Impact:
Reduces the disk I/O and latency of bulk worktree creation operations from O(N) to O(1). This completely eliminates the unnecessary synchronous/asynchronous file reads during iteration and improves overall system throughput.
🔬 Measurement:
Run
pnpm testandpnpm lintand inspectapps/agor-daemon/src/services/worktrees.tsto ensure thatloadConfigexecutes once outside the loop.PR created automatically by Jules for task 16661565703369552395 started by @Donach