⚡ Bolt: Optimize bulk worktree creation by hoisting loadConfig#60
⚡ Bolt: Optimize bulk worktree creation by hoisting loadConfig#60Donach wants to merge 1 commit into
Conversation
Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Hoisted
loadConfig()out ofapplyWorktreeCreateDefaultswhen used in array mapping context.🎯 Why: When
WorktreesService.createis invoked with an array of items, it usesPromise.allto concurrently callapplyWorktreeCreateDefaultsfor each item. Before this patch,applyWorktreeCreateDefaultswas unconditionally awaitingloadConfig()per call, causing N simultaneous configuration file loads/parses leading to severe latency for bulk creates.📊 Impact: Reduces disk I/O and parsing overhead from
O(N)toO(1)during bulk creations.🔬 Measurement: Benchmarking
Promise.allcallingloadConfigmultiple times shows immediate speedup locally. Verified via the comprehensive daemonvitestsuite.PR created automatically by Jules for task 15108171954413516725 started by @Donach