🛡️ Sentinel: [CRITICAL] Fix command injection in Unix ID lookups#59
Conversation
Refactor `execSync` to `execFileSync` to address a critical security vulnerability where dynamic inputs (`username` and `groupName`) were unsafely evaluated within a shell context. Added argument array passing and `--` prefix to additionally prevent argument injection. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability:
execSyncused template literals incorporating unsanitized dynamic inputs (username,groupName) inpackages/core/src/unix/id-lookups.ts. A malicious string could result in arbitrary command execution as the string is evaluated within a shell.🎯 Impact: Command injection allows an attacker to execute arbitrary shell commands on the host operating system with the privileges of the running application.
🔧 Fix: Replaced
execSyncwithexecFileSync. Commands and their arguments are now passed distinctly in an array instead of being interpolated into a shell string. Furthermore, dynamic parameters are prefixed with--to eliminate argument injection.✅ Verification: Run
pnpm testandpnpm lintand observe passing checks. The fallback logic relies identically onexecFileSynccontinuing to throw errors for missing groups/users.PR created automatically by Jules for task 9192722922093521289 started by @Donach